Skip to content

topology2: cavs-rt5682: Assign RTC_AEC to secondary core (depends on PR 8469) #8455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kv2019i merged 1 commit into from
Jan 4, 2024
Merged

topology2: cavs-rt5682: Assign RTC_AEC to secondary core (depends on PR 8469) #8455

kv2019i merged 1 commit into from
Jan 4, 2024

Conversation

@yongzhi1
Copy link
Contributor

@yongzhi1 yongzhi1 commented Nov 7, 2023

Run RTC_AEC module on core 1 to balance workloads.

@yongzhi1 yongzhi1 marked this pull request as draft November 7, 2023 17:53
@yongzhi1 yongzhi1 marked this pull request as ready for review November 9, 2023 22:53
@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Nov 9, 2023

Depends on #8469.

lgirdwood
lgirdwood approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lkoenig
lkoenig reviewed Nov 17, 2023
View reviewed changes
tools/topology/topology2/sof-ace-tplg/tplg-targets.cmake Outdated
SPK_ID=6,SPEAKER_SSP_DAI_INDEX=0,HEADSET_CODEC_NAME=SSP2-Codec,SPEAKER_CODEC_NAME=SSP0-Codec,\
BT_NAME=SSP1-BT,BT_INDEX=1,BT_ID=7,BT_PCM_NAME=Bluetooth,INCLUDE_ECHO_REF=true,USE_CHAIN_DMA=true,\
DEEPBUFFER_D0I3_COMPATIBLE=true,GOOGLE_RTC_AEC_SUPPORT=1"
DEEPBUFFER_D0I3_COMPATIBLE=true,GOOGLE_RTC_AEC_SUPPORT=1,GOOGLE_AEC_DP_CORE_ID=1"
Copy link
Contributor

@lkoenig lkoenig Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to go for Core 2 so nothing else is running on it ?

Copy link
Contributor Author

@yongzhi1 yongzhi1 Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, let's keep core0 at arm's length 😉

@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Nov 18, 2023

Update:
Move RTC_AEC module to core 2.

@lgirdwood
Copy link
Member

lgirdwood commented Nov 20, 2023

@lkoenig good for you now ?

@lkoenig
Copy link
Contributor

lkoenig commented Nov 24, 2023

@lkoenig good for you now ?
If someone did test it on hardware I am good. Otherwise I'll give it a try today.

@lgirdwood
Copy link
Member

lgirdwood commented Nov 30, 2023

@lkoenig good for you now ?
If someone did test it on hardware I am good. Otherwise I'll give it a try today.

@yongzhi1 has been testing alongside others.

@lgirdwood
Copy link
Member

lgirdwood commented Nov 30, 2023

@kv2019i fyi.

@kv2019i kv2019i changed the title topology2: cavs-rt5682: Assign RTC_AEC to secondary core topology2: cavs-rt5682: Assign RTC_AEC to secondary core (depends on PR 8469) Dec 5, 2023
@kv2019i
Copy link
Collaborator

kv2019i commented Dec 5, 2023

@yongzhi1 I added the depends on to the summary, please correct if this no longer holds. I've been holding off merge due to the dependency.

@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Dec 6, 2023

@yongzhi1 I added the depends on to the summary, please correct if this no longer holds. I've been holding off merge due to the dependency.

sure, it was tested on mtl-007-drop-stable only, thanks!!

@lgirdwood
Copy link
Member

lgirdwood commented Dec 8, 2023

@yongzhi1 conflicts.

@yongzhi1
topology2: cavs-rt5682: Assign RTC_AEC to secondary core
db1b00e 
Run RTC_AEC module on core 2 to balance workloads.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Dec 8, 2023

Rebased, thanks!

@lgirdwood
Copy link
Member

lgirdwood commented Dec 18, 2023

@yongzhi1 any update on dependencies being merged ?

@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Jan 2, 2024

@yongzhi1 any update on dependencies being merged ?

Hi, @lgirdwood @kv2019i think it's OK to merge this patch now as AEC issues were opened any way :)

@kv2019i kv2019i merged commit 1f3cf75 into thesofproject:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkoenig lkoenig lkoenig left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski

@abonislawski abonislawski Awaiting requested review from abonislawski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yongzhi1 @lgirdwood @lkoenig @kv2019i