[mtl-006] Port multicore fix to mtl-006-drop-stable branch #8179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
mengdonglin
changed the title
mengdonglin
changed the title
Collaborator
|
@serhiy-katsyuba-intel @tmleman @abonislawski This PR includes #8149 on main branch to fix issue #8155 Can you please review? |
Contributor
|
Build failed, can you fix the build errors? I can quickly verify if this really fix the multicore problem. |
Contributor
|
I fixed the build error and checking with mtl-006-stable-drop diff --git a/src/ipc/ipc4/handler.c b/src/ipc/ipc4/handler.c
index 845b71fa6b9c..443e593f0d76 100644
--- a/src/ipc/ipc4/handler.c
+++ b/src/ipc/ipc4/handler.c
@@ -67,7 +67,7 @@ static struct ipc4_msg_data msg_data;
/* fw sends a fw ipc message to send the status of the last host ipc message */
static struct ipc_msg msg_reply = {0, 0, 0, 0, LIST_INIT(msg_reply.list)};
-static struct ipc_msg msg_notify = {0, 0, 0, 0, LIST_INIT(msg_notify.list)}};
+static struct ipc_msg msg_notify = {0, 0, 0, 0, LIST_INIT(msg_notify.list)};
/*
* Global IPC Operations. |
Contributor
|
unfortunately, different IPC timeout came up when GLB_CREATE_PIPELINE |
RanderWang
force-pushed
the
006_multicore
branch
from
5f6c474 to
3a5bdfa
Compare
Collaborator
Author
|
Let me check 006, I only tested main. Thanks! |
Contributor
|
with 2nd push, there is no build error, but back to MOD_SET_DX error |
Collaborator
Author
|
Add more debug method and find the fw hang after set_dx to disable secondary core. It will be always failed with create_pipeline after set_dx |
serhiy-katsyuba-intel
approved these changes
Sep 8, 2023
Member
lgirdwood
approved these changes
Sep 11, 2023
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@mwasko @marcinszkudlinski fyi merged into main last week and results good.
abonislawski
approved these changes
Sep 13, 2023
marcinszkudlinski
approved these changes
Sep 13, 2023
Contributor
|
@RanderWang there is quite a lof of CI sof-ci/jenkins/pr-device-test/main-ace failures on MTL, can you clarify this? |
RanderWang
force-pushed
the
006_multicore
branch
from
3a5bdfa to
3dc2a23
Compare
Collaborator
Author
|
The FW building was failed with error but it has nothing to do with my PR. /zep_workspace/sof/src/schedule/zephyr_domain.c:26:10: fatal error: zephyr/timeout_q.h: No such file or directory
26 | #include <zephyr/timeout_q.h>
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated. |
pjdobrowolski
force-pushed
the
mtl-006-drop-stable
branch
from
becf889 to
d32f1f2
Compare
pjdobrowolski
force-pushed
the
mtl-006-drop-stable
branch
from
d32f1f2 to
3a06939
Compare
softwarecki
force-pushed
the
mtl-006-drop-stable
branch
from
bf7e8ae to
37bd281
Compare
Collaborator
Author
|
SOFCI TEST |
In multicore case, IPC message is dispatched from primary core to secondary core which send reply message to host. Primary core will do nothing if IPC_TASK_SECONDARY_CORE is set. But in rare case, the secondary code finish the reply message and clear this flag before the ipc thread in primary core check this flag, then primary core also send reply message again. This results to the reply message being inserted two times in ipc message list and infinite loop when visiting the list. We don't need to init reply message since it is initialized after deleting from the ipc list. Signed-off-by: Rander Wang <rander.wang@intel.com>
Use list_is_empty to check the message is queued or not. The notify message is initialized to empty after deleting from the ipc msg list. We use the same idea in ipc_msg_send. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
006_multicore
branch
from
3dc2a23 to
593d985
Compare
Collaborator
Author
|
the error only happened on mtl-sdw device and it is a regression issue on 006branch. @keqiaozhang is working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check #8143 and #8149
All CI multi-core tests pass on main branch!