Skip to content

topology2: nocodec-multicore: Add connected pipelines #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Jul 11, 2023
Merged

topology2: nocodec-multicore: Add connected pipelines #7847

lgirdwood merged 1 commit into from
Jul 11, 2023

Conversation

@yongzhi1
Copy link
Contributor

@yongzhi1 yongzhi1 commented Jun 21, 2023 •
edited
Loading

Tested multi-stream capture on core1.

@yongzhi1 yongzhi1 requested review from jsarha and ranj063 as code owners June 21, 2023 21:05
@yongzhi1 yongzhi1 marked this pull request as draft June 21, 2023 21:05
@yongzhi1 yongzhi1 force-pushed the connected-pipe branch 2 times, most recently from 4f6fd74 to 1e3f2f8 Compare June 22, 2023 23:39
@yongzhi1
topology2: nocodec-multicore: test multi-stream capture
5837f7b 
Enable more complex pipelines for multi-core use cases.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
@yongzhi1 yongzhi1 requested a review from RanderWang July 7, 2023 20:56
@yongzhi1 yongzhi1 changed the title [TEST]: topology2: nocodec-multicore: Add connected pipelines topology2: nocodec-multicore: Add connected pipelines Jul 7, 2023
@yongzhi1 yongzhi1 marked this pull request as ready for review July 7, 2023 20:57
@lgirdwood
Copy link
Member

lgirdwood commented Jul 10, 2023

@ranj063 @jsarha any comments ?

@jsarha
Copy link
Contributor

jsarha commented Jul 10, 2023

Already approved, but I have minor nitpick. Maybe the PASSTRHOUGH variable could have more descriptive name, like DMIC_SFX_ENABLE. I would also encourage to always write some comments about what these new PCMs and pipelines are for, when adding them.

@lgirdwood
Copy link
Member

lgirdwood commented Jul 10, 2023

Already approved, but I have minor nitpick. Maybe the PASSTRHOUGH variable could have more descriptive name, like DMIC_SFX_ENABLE. I would also encourage to always write some comments about what these new PCMs and pipelines are for, when adding them.

@yongzhi1 can you make this an incremantal update. Thanks.

@yongzhi1
Copy link
Contributor Author

yongzhi1 commented Jul 10, 2023

@yongzhi1 can you make this an incremantal update. Thanks.

Ack, the code was moved from the cavs-nocodec.conf based on #6783, maybe we can use the regular nocodec version for multi-core support, eventually.

@lgirdwood
Copy link
Member

lgirdwood commented Jul 11, 2023

SOFCI TEST

@lgirdwood lgirdwood merged commit e23857b into thesofproject:main Jul 11, 2023
@fredoh9 fredoh9 mentioned this pull request Jul 12, 2023
Closed
@RanderWang RanderWang mentioned this pull request Jul 17, 2023
Closed
@yongzhi1 yongzhi1 deleted the connected-pipe branch April 26, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsarha jsarha jsarha approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@RanderWang RanderWang RanderWang approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yongzhi1 @lgirdwood @jsarha @RanderWang