Skip to content

dai-zephyr: do not set local buffer if no process func found #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kv2019i wants to merge 1 commit into from
Closed

dai-zephyr: do not set local buffer if no process func found #7690

kv2019i wants to merge 1 commit into from

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented May 25, 2023

Rework set_new_local_buffer() to not set dd->local_buffer multiple times.

@kv2019i kv2019i requested a review from lyakh May 25, 2023 13:08
@kv2019i
Copy link
Collaborator Author

kv2019i commented May 25, 2023

Not sure @lyakh this helps much, but we do avoid one extra dd->local_buffer write.

@kv2019i kv2019i mentioned this pull request May 25, 2023
Merged
juimonen
juimonen approved these changes May 26, 2023
View reviewed changes
Copy link

@juimonen juimonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand the optimization, but looks innocent enough to me

lyakh
lyakh requested changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing it! But need to fix one hick up.

@lyakh
Copy link
Collaborator

lyakh commented May 26, 2023

@kv2019i @juimonen Given two possibilities:

	never_fails();
	ret = might_fail();
	if (ret < 0) {
		undo_never_fails();
		return ret;
	}

and

	ret = might_fail();
	if (ret < 0)
		return ret;

	never_fails();

as long as the order indeed isn't important - often both will work correctly, but I think one is clearly preferable over the other and should be used whenever possible.

btian1
btian1 reviewed May 29, 2023
View reviewed changes
@kv2019i
dai-zephyr: do not set local buffer if no process func found
1ac1ea1 
Rework set_new_local_buffer() to not set dd->local_buffer multiple
times. Also remove erroneous __sparse_cache attribute for "local_buf".

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202305-local-buffer-set-refactor branch from 55ceca3 to 1ac1ea1 Compare June 5, 2023 12:49
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 5, 2023

V2 uploaded, please review.

@kv2019i kv2019i requested review from btian1 and lyakh June 5, 2023 16:06
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 6, 2023

The Intel CI System/merge/build fails to one run of "TestSrcFullScope::test_01_04_src" indicating a glitch on one platform. I don't think it can be related to this PR, but need to do another run to be sure.

@lgirdwood
Copy link
Member

lgirdwood commented Jul 4, 2023

SOFCI TEST

@lgirdwood
Copy link
Member

lgirdwood commented Jul 4, 2023

@kv2019i still failing CI, can you check. Thanks

@kv2019i kv2019i closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakh lyakh lyakh approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@btian1 btian1 btian1 approved these changes

@dnikodem dnikodem dnikodem approved these changes

@tmleman tmleman tmleman approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

+1 more reviewer

@juimonen juimonen juimonen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kv2019i @lyakh @lgirdwood @juimonen @btian1 @dnikodem @tmleman