Skip to content

xtensa-build-zephyr.py: stop calling west sign, rely on west build #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kv2019i merged 2 commits into from
May 26, 2023
Merged

xtensa-build-zephyr.py: stop calling west sign, rely on west build #7684

kv2019i merged 2 commits into from
May 26, 2023

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 24, 2023 •
edited
Loading

Move rimage parameters to west config instead of passing them to west sign directly.

Final part closing:

+ 1 other commit. See commit messages.

cc:

@marc-hb marc-hb mentioned this pull request May 24, 2023
Closed
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 24, 2023 •
edited
Loading

The failure https://github.com/thesofproject/sof/actions/runs/5074180192/jobs/9114081700?pr=7684 is known issue #7675, work in progress. This build script change is totally unrelated to fuzzing.

The failures in https://sof-ci.01.org/sofpr/PR7684/build8467/devicetest/index.html seem related to thesofproject/sof-test#1039 - and unrelated to this build script change.

The few failures in https://sof-ci.01.org/sofpr/PR7684/build8466/devicetest/index.html are also known and unrelated.

https://sof-ci.01.org/sof-pr-viewer/#/build/PR7684/build12059408 is the usual and infamous

16:29:46,885 INFO  - Running step...
17:01:04,696 INFO  - Executing post-execute action...
17:01:04,696 ERROR - Step 'master>SCANS>TESTS>TRIGGER PYTHON SMOKE_IPC4 TESTS' is failed: Step is failed since the triggered build is failed, cancelled, or timed out.

@wszypelt can you fix again?

PS: this test run was cursed!!

@marc-hb marc-hb marked this pull request as ready for review May 25, 2023 00:46
@marc-hb marc-hb added this to the v2.6 milestone May 25, 2023
kv2019i
kv2019i approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, just in time for v2.6.

@wszypelt
Copy link

wszypelt commented May 25, 2023

SOFCI TEST

@wszypelt
Copy link

wszypelt commented May 25, 2023 •
edited
Loading

@marc-hb in python tests i see a problem with sdw ;/

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 25, 2023

Looks great, thanks, just in time for v2.6.

Apparently got beaten by a concurrent west.yml uprev, need to rebase.

SOFCI TEST

Only sof-ci/jenkins (which I did NOT ask you about :-) cares about these magic keywords

@marc-hb in python tests i see a problem with sdw ;/

Do you mean this below ? Totally different from quickbuild, should be fixed now.

https://sof-ci.01.org/sofpr/PR7684/build8467/devicetest/index.html

RMMOD	regmap_sdw
rmmod: ERROR: Module regmap_sdw is in use by: snd_soc_rt712_sdca_dmic snd_soc_rt712_sdca

marc-hb added 2 commits May 25, 2023 18:05
@marc-hb
xtensa-build-zephyr.py: add new rimage_west_configuration()
0a1f923 
Do not make the switch yet. Make the switch in a smaller commit that can
more easily be reverted in case of a bug or some missed dependency
somewhere.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
xtensa-build-zephyr.py: stop calling west sign, rely on west build
9212cfe 
Stop invoking west sign manually. Configure rimage using `west config`
and a platform-specific WEST_CONFIG_LOCAL file instead, then rely on
west build to invoke rimage.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb force-pushed the west-build-sign branch from 4cbabeb to 9212cfe Compare May 25, 2023 18:06
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 25, 2023

Old IPC fuzzer failure https://github.com/thesofproject/sof/actions/runs/5083146240/jobs/9133786204?pr=7684 is known, will be fixed by 7675

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 25, 2023 •
edited
Loading

Wow, https://sof-ci.01.org/sofpr/PR7684/build8556/devicetest/index.html is all green and https://sof-ci.01.org/sofpr/PR7684/build8555/devicetest is looking great too except for one MODEL missing.

Even https://sof-ci.01.org/sof-pr-viewer/#/build/PR7684/build12065661 is green, it's party time.

Maybe Kai's #7660 is making an even bigger difference than expected?

@kv2019i
Copy link
Collaborator

kv2019i commented May 26, 2023

FYI @abonislawski @aborisovich . Looks good, proceeding with merge.

@kv2019i kv2019i merged commit a769d39 into thesofproject:main May 26, 2023
@marc-hb marc-hb deleted the west-build-sign branch September 26, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019i kv2019i kv2019i approved these changes

@aborisovich aborisovich Awaiting requested review from aborisovich

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@andyross andyross Awaiting requested review from andyross

@paulstelian97 paulstelian97 Awaiting requested review from paulstelian97

@keqiaozhang keqiaozhang Awaiting requested review from keqiaozhang

@dcpleung dcpleung Awaiting requested review from dcpleung

@aiChaoSONG aiChaoSONG Awaiting requested review from aiChaoSONG

+1 more reviewer

@juimonen juimonen juimonen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.6

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-hb @wszypelt @kv2019i @juimonen