[SKIP SOF-TEST] .github/codestyle: drop spurious *.yml pattern #7632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suddenly failed in for PR thesofproject#7551 in https://github.com/thesofproject/sof/actions/runs/4998109337/ jobs/8953192254 I have no idea why it never failed earlier (new yamllint version maybe?) but it's always been wrong and should have never been there anyway. Fixes commit 3d69a7f (".github: extend yamllint line-length to 100") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
aborisovich,
cujomalainey,
dbaluta and
lgirdwood
as code owners
Collaborator
Author
|
zmain failure is known and unrelated: #7614 |
dbaluta
approved these changes
May 17, 2023
Collaborator
|
The original commit says that it added that pattern specifically so west.yml is also covered. Do we not want that? |
kv2019i
requested changes
May 17, 2023
| run: yamllint -f parsable | ||
| -d "$yamllint_config" | ||
| --strict .github/workflows/*.yml *.yml | ||
| --strict .github/workflows/*.yml |
Collaborator
There was a problem hiding this comment.
Is it spurious, mianline has sof/west.yml (but 2.2 stable does not and thus the fail in 7551)?
Collaborator
Author
|
Thanks, I need more sleep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suddenly failed in for PR #7551 in
https://github.com/thesofproject/sof/actions/runs/4998109337/jobs/8953192254
I have no idea why it never failed earlier (new yamllint version maybe?) but it's always been wrong and should have never been there anyway.
Fixes commit 3d69a7f (".github: extend yamllint line-length to 100")