Skip to content

Conversation

@Vamshigopal
Copy link
Contributor

@Vamshigopal Vamshigopal commented May 12, 2023

We have the fix #7577 merged in main branch.
As we need this fix in production devices, please merge the fix in cavs2.5-001-drop-stable.

@Vamshigopal
Copy link
Contributor Author

Vamshigopal commented May 12, 2023

@marc-hb
Copy link
Collaborator

marc-hb commented May 12, 2023

Please use cherry-pick -x for backports.

kv2019i added 2 commits May 15, 2023 09:51
If DMA is active, do not read data directly from the SSP
RX fifo.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
(cherry picked from commit e94071f)
If DMA transaction is ongoing when RX is enabled, this can lead
to stuck communication between DMA and SSP (DMA service request
not seen by the DMA).

To avoid this, flush the RX fifo before enabling SSP RX.

Link: thesofproject#7548
Suggested-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
(cherry picked from commit 4a4d8d2)
@Vamshigopal
Copy link
Contributor Author

Please use cherry-pick -x for backports.

Ack, updated the commits. Thanks.

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also backported to v2.2 #7601

@mwasko mwasko merged commit 2c3f370 into thesofproject:cavs2.5-001-drop-stable May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants