copier: preparation for copier module adapter interface #7598
Conversation
src/audio/pipeline/pipeline-params.c
Outdated
There was a problem hiding this comment.
not true for multi endpoint DAI yet
There was a problem hiding this comment.
ok, seems I put too much in one patch again, let me split and upload with new patches.
There was a problem hiding this comment.
since multi-endpoint PR merged, seems this part of change need involve again, let me try to submit a new patch to cover this.
btian1
force-pushed
the
remove_notstandard
branch
3 times, most recently
from
c3b497d to
699aa4a
Compare
src/audio/dai-legacy.c
Outdated
There was a problem hiding this comment.
I think you need to keep this for now.
btian1
force-pushed
the
remove_notstandard
branch
from
699aa4a to
eae9842
Compare
btian1
changed the title
btian1
changed the title
btian1
requested review from
RanderWang,
abonislawski,
dbaluta,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
btian1
changed the title
btian1
force-pushed
the
remove_notstandard
branch
from
eae9842 to
25f2275
Compare
btian1
force-pushed
the
remove_notstandard
branch
from
25f2275 to
128b5dd
Compare
|
@btian1 ADL nocodec has failures on playback. Can you please check? |
btian1
force-pushed
the
remove_notstandard
branch
2 times, most recently
from
ff174e8 to
1f2cf9d
Compare
btian1
force-pushed
the
remove_notstandard
branch
from
1f2cf9d to
975bb2a
Compare
|
trying to resolve remove copier part, however failed with cmocka part, trying to figure out how to call common_get_hw_params in cmocka. Tried with add dai-legacy.c into cmocka CMakeLists.txt, however, this will brings more errors, trying in isolate the common function in header file. |
btian1
force-pushed
the
remove_notstandard
branch
11 times, most recently
from
27f58a6 to
eab21e0
Compare
src/audio/pipeline/pipeline-params.c
Outdated
There was a problem hiding this comment.
Not specific to this commit, but with the recent copier / DAI integration work, I'm a bit concerned about mixing up of the layers. Now we have copier and DAI layers mixing in with the pipeline code. Is that an intermediate step or is it what we want eventually?
There was a problem hiding this comment.
I understand.
Before this change, the get hw params operation still looks very strange, it calls it by an inline ops driver interface, and this interface is not an standard for module adapter, so this is why this patch exists.
Regarding the change, due to we have to support multiple cases(otherwise, CI will report error)
looks a little redundant, maybe one day, ipc3 support was totally removed from SOF, then we may figure out a better way to implement this get hw params.
currently, seems this is the only way to remove this interface from copier.
btian1
force-pushed
the
remove_notstandard
branch
3 times, most recently
from
e6e6ae3 to
03793ab
Compare
inside dai-zephyr/legacy, there is no need to call comp_dai_get_hw_params, dai_zephyr_get_hw_params can be directly called without wrap, remove the dpendency in dai-zephyr/legacy. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
COMP_ATTR_VDMA_INDEX is a copier internal usage case, no other module used, so remove and replace it with direct assign. At the same time, this keep get_attribute align with module adapter format. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Change function name from: dai_zephyr_get_hw_params to dai_common_get_hw_params, due to this name also exist in dai-legacy.c, need align both legacy and zephyr part to avoid misunderstanding. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
btian1
force-pushed
the
remove_notstandard
branch
from
03793ab to
b084675
Compare
|
Known fails in https://sof-ci.01.org/sofpr/PR7598/build8568/devicetest/index.html and https://sof-ci.01.org/sofpr/PR7598/build8567/devicetest/index.html . Proceeding with merge. |
5 participants
no change for functionality, changes list below:
This is for preparation of copier module interface.