[SKIP CI] .github/zephyr: build with the debug overlay and CONFIG_ASSERT #7508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twice faster than shallow clones without any of the git describe or other hassle. More info in zephyrproject-rtos/west#638 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
gha-debug-assert
branch
2 times, most recently
from
8a8ff86 to
30634de
Compare
This makes sure Zephyr's -fmacro-prefix-map is working and keeps the builds reproducible when using a recent enough toolchain. As found in the CONFIG_ASSERT PR thesofproject#6530 (comment) this is not true for old Xtensa toolchains. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
gha-debug-assert
branch
from
30634de to
223ea05
Compare
Collaborator
Author
|
|
marc-hb
requested review from
aborisovich,
cujomalainey,
dbaluta and
lgirdwood
as code owners
marc-hb
requested review from
aiChaoSONG,
andyross,
dcpleung,
greg-intel,
keqiaozhang,
kv2019i and
paulstelian97
paulstelian97
approved these changes
Apr 25, 2023
Collaborator
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
This is extremely interesting, if it also works then way to go!
kv2019i
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure Zephyr's -fmacro-prefix-map is working and keeps the
builds reproducible when using a recent enough toolchain.
As found in the CONFIG_ASSERT PR
#6530 (comment)
this is not true for old Xtensa toolchains.