[SKIP CI] ci: add cherry-pick check for release branches #7263
Conversation
cujomalainey
requested review from
aborisovich,
dbaluta,
lgirdwood and
marc-hb
as code owners
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I like the idea.
Could you make https://github.com/cujomalainey/cherry-pick-check/blob/main/entrypoint.sh a bit more shellcheck-compliant?
Can you also add set -e?
A main function would also be nice:
|
I have barely looked at https://github.com/cujomalainey/cherry-pick-check/blob/main/entrypoint.sh yet but based on the desired feature I just remembered it must be doing something like this old script of mine which is very well tested: A while back I searched for a Github Action that would return the list of submitted commits but all the ones I found surprisingly sucked. I guess it's because most Github users use commits only for "fixups" zephyrproject-rtos/zephyr#53566 There's also the shallow cloning problem: thesofproject/linux#2556, fortunately sof.git is small enough. Also on my way too long reading list: https://docs.github.com/en/actions/using-workflows/reusing-workflows |
That appears to be missing the parent branch check part though. That being said, I admit that is half the script. |
Add a non mandatory check for release branches that help reviewers verify all patches have landed on main before the patch to release branch. The current configuration requires the cherry-pick command to be run with -x. This can be configured to do subject matching if that is too much for developers. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
changed the title
|
@marc-hb shellcheck passes now, I also fixed yaml, if it looks good to you on action side I will push a new release and update the PR. |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Script review in cujomalainey/cherry-pick-check#1
4 participants
Add a non mandatory check for release branches that help reviewers verify all patches have landed on main before the patch to release branch.
The current configuration requires the cherry-pick command to be run with -x. This can be configured to do subject matching if that is too much for developers.