topology2: add WoV test topology on HDA platform #7236
Conversation
aiChaoSONG
requested review from
aborisovich,
jsarha,
marc-hb and
ranj063
as code owners
This patch adds the WoV test topology on HDA platform. Signed-off-by: Chao Song <chao.song@linux.intel.com>
| # HDA topology with WoV enabled | ||
| "sof-hda-generic\;sof-mtl-hda-generic-2ch-kwd\;PLATFORM=mtl,HDA_CONFIG=mix,NUM_DMICS=2,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-hda-generic-2ch-kwd.bin,INCLUDE_WOV=true,\ | ||
| DEEPBUFFER_FW_DMA_MS=100" |
There was a problem hiding this comment.
should we have test modules in generic, used in real devices, products topology? I don't really want to have this on my personal laptop, to be honest...
There was a problem hiding this comment.
@ujfalusi This is in development/ folder, not to be shipped (e.g. sod-hda-src-generic is not shipped).
There was a problem hiding this comment.
Oh, right, it was not indicated in commit title or message..
| # HDA topology with WoV enabled | ||
| "sof-hda-generic\;sof-mtl-hda-generic-2ch-kwd\;PLATFORM=mtl,HDA_CONFIG=mix,NUM_DMICS=2,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-hda-generic-2ch-kwd.bin,INCLUDE_WOV=true,\ | ||
| DEEPBUFFER_FW_DMA_MS=100" |
There was a problem hiding this comment.
@ujfalusi This is in development/ folder, not to be shipped (e.g. sod-hda-src-generic is not shipped).
| # HDA topology with WoV enabled | ||
| "sof-hda-generic\;sof-mtl-hda-generic-2ch-kwd\;PLATFORM=mtl,HDA_CONFIG=mix,NUM_DMICS=2,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-hda-generic-2ch-kwd.bin,INCLUDE_WOV=true,\ | ||
| DEEPBUFFER_FW_DMA_MS=100" |
There was a problem hiding this comment.
Oh, right, it was not indicated in commit title or message..
| DMIC1_HOST_PIPELINE_SINK 'copier.host.16.1' | ||
| DMIC_WOV_DAI_PIPELINE_SRC 'copier.DMIC.17.1' | ||
| DMIC_WOV_DAI_PIPELINE_KPB 'kpb.17.1' | ||
| WOV_PIPELINE_SINK 'micsel.18.1' |
There was a problem hiding this comment.
The dmic-default.conf defines this:
WOV_PIPELINE_SINK 'micsel.20.1'
and most of these are also found in there, so we change them here? Why not in there?
There was a problem hiding this comment.
dmic-default.conf defines the default values used commonly for dmic, in most cases, if there is exception, we should do the change in the top-level topology.
5 participants
This patch adds the WoV test topolgy on HDA platform.
Previously #7106.
WoV feature test topology was added on nocodec platform, however, for MTL, there is pin conflict between SSP2 and DMIC, so we add WoV test topology on HDA platform.
This patch only adds topology for MTL, because MTL requires
DMIC_DRIVER_VERSION==3, this is not true for TGL/ADL, it is not possible to use one topology for both. If needed, we can add a new topology for TGL/ADL, too.