[SKIP CI] .github/daily-tests.yml: add sparse-zephyr.yml #7203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because why not. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
aborisovich,
cujomalainey,
dbaluta and
lgirdwood
as code owners
Collaborator
Author
|
In https://github.com/thesofproject/sof/actions/runs/4318983392/jobs/7537920586 checkpatch is clueless and wrong |
kv2019i
approved these changes
Mar 3, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Makes sense to add this as well, but I'd still add a bit of background to the git commit message.
| uses: ./.github/workflows/pull-request.yml | ||
| run-zephyr-builds: | ||
| uses: ./.github/workflows/zephyr.yml | ||
| sparse-zephyr: |
Collaborator
There was a problem hiding this comment.
I'd argue some better rationale could be added to the git commit that "why not".
Collaborator
Author
There was a problem hiding this comment.
Fair enough, I should probably have said something better like "there is no reason to exclude sparse from daily tests" :-)
Thanks for not blocking this.
lgirdwood
approved these changes
Mar 3, 2023
Contributor
|
Because that's why: Please hotfix. |
Collaborator
Author
|
Thanks for spotting this, tentative fix submitted in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because why not.