mixin-mixout: fix 2 corner cases #7131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
num_input_buffers in module_single_sink_setup() and num_output_buffers in module_single_source_setup() don't have to be incremented inside the loop together with the loop counter i. Just assign them after the loops. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
When calculating the number of frames to produce, ignore inactive and empty inputs. On the one hand an inactive empty input shouldn't block producing data from active or non-empty inputs. OTOH if an inactive input has pending data, it should be used instead of letting the data stall. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
If audio_stream_set_zero() fails in mixout_process(), the output data size should be set to 0. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
.process() callback receives input and output buffer arrays as function arguments, no need to fetch them from the module object again. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
reviewed
Feb 21, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Other patches ok, but not sure about the behaviour change in the second patch. Please see question inline.
lgirdwood
approved these changes
Feb 21, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a case of empty or inactive sources and
audio_stream_set_zero()error handling