Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Feb 16, 2023

Follow-up to #7102 with fixes to Zephyr and SOF to make the SOF testsi using DW-DMA to pass.

The component state dependent actions in dai_comp_trigger_internal()
are not working as intended as dev->state is already updated to
new target state at the start of the function. Update the logic
to correctly evaluate previous state in trigger actions.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To ensure DMA is stopped in all cases, we need to call dma_stop()
also when the previous state is PAUSED.

With Zephyr commit ec9d94e06d4a ("dma: Document expected behavior of
start/stop") the dma interface semantics were clarified. Build on
this and call dma_stop() in all cases and make the code simpler to
follow.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Update Zephyr to latest version plus cherry-pick PR54900
zephyrproject-rtos/zephyr#54900
on top.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202302-feb16-zephyr-update-test branch from 074ed65 to cc5b539 Compare February 16, 2023 18:15
@kv2019i kv2019i changed the title [DNM] west.yml: upgrade Zephyr to 4d4e25292faa247 + PR54900 backport [DNM] west.yml: upgrade Zephyr to 8f34181e3dd73fa7 + PR54900 backport Feb 16, 2023
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 16, 2023

@lyakh sparse-mtl check passing! :)

@aiChaoSONG
Copy link
Collaborator

@marc-hb any idea what the github action build failure

fatal: expected 'acknowledgments'
Error: Process completed with exit code 128.

is.

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 17, 2023

You forgot the link: https://github.com/thesofproject/sof/actions/runs/4196943245/jobs/7278612315

@marc-hb any idea what the github action build failure fatal: expected 'acknowledgments'

Yes that's because we use west fetch --narrow to speed things up and it's unfortunately incompatible with SHA1s :-(

The alternative is to use a branch name. This can be pull/12345/head or pull/12345/merge if there is a pull request (but it does not have to be).

@sys-pt1s
Copy link

sys-pt1s commented Apr 6, 2023

Can one of the admins verify this patch?

@kv2019i kv2019i closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants