topology2: enable WoV on mtl hda platform #7106
Conversation
enable WoV on mtl hda platform Signed-off-by: Libin Yang <libin.yang@intel.com>
libinyang
requested review from
aborisovich,
dbaluta,
lbetlej,
lgirdwood,
marc-hb,
mmaka1 and
plbossart
as code owners
|
it depends on kernel PR 4185 |
| NHLT_BIN=nhlt-sof-hda-generic-4ch.bin,DEEPBUFFER_FW_DMA_MS=100" | ||
| "sof-hda-generic\;sof-hda-generic-2ch\;PLATFORM=mtl,\ | ||
| HDA_CONFIG=mix,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-2ch.bin,\ | ||
| HDA_CONFIG=mix,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-2ch.bin,INCLUDE_WOV=true,\ |
There was a problem hiding this comment.
why only MTL, why not TGL/ADL too?
|
Please remove rimage change @libinyang |
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
NAK for a change to generic topologies. Let's not confuse tests and release.
| NHLT_BIN=nhlt-sof-hda-generic-4ch.bin,DEEPBUFFER_FW_DMA_MS=100" | ||
| "sof-hda-generic\;sof-hda-generic-2ch\;PLATFORM=mtl,\ | ||
| HDA_CONFIG=mix,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-2ch.bin,\ | ||
| HDA_CONFIG=mix,NUM_DMICS=2,PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-hda-generic-2ch.bin,INCLUDE_WOV=true,\ |
There was a problem hiding this comment.
That's a no for me. These topologies will be released externally, no way we are going to add a pretend WOV that makes no sense.
if you want to add WOV for tests, then that has to be done in a development topology or a CI one.
There was a problem hiding this comment.
That's a no for me. These topologies will be released externally, no way we are going to add a pretend WOV that makes no sense.
if you want to add WOV for tests, then that has to be done in a development topology or a CI one.
@plbossart I forgot to add "Draft" on it. This is not a final solution, but a reference code. The final solution is, as Liam suggested in #7047 (review), that we will create a test tplg for it. Sorry for the inconvenience.
There was a problem hiding this comment.
what you want is to extend a topology for tests not create a new one. We've done this already with deep-buffer that are not released, etc.
|
Can one of the admins verify this patch? |
|
I will file a new one, close |
5 participants
enable WoV on mtl hda platform