Skip to content

Conversation

@jairaj-arava
Copy link
Contributor

These changes adds a second stream for DMIC to the MTL Chromebook topology. The second stream can be used as a reference stream by the user. All the needed supporting changes were already merged via #6783.
Verified the functionality by simulataneously capturing data via both the streams and didn't see any issue in the recorded data as of now.
image

@jairaj-arava
Copy link
Contributor Author

@RanderWang
Copy link
Collaborator

@jairaj-arava is there array of four DMIC for rt5682 ? or two ? If only two, we don't need to support 4 channel stream

@plbossart
Copy link
Member

plbossart commented Feb 15, 2023

@jairaj-arava is there array of four DMIC for rt5682 ? or two ? If only two, we don't need to support 4 channel stream

@RanderWang for Chromebooks we always assume there are four mics, and then CRAS removes the channels that don't exist using the mapping found in the platform-specific UCM extensions. At the fimware/topology level we always expose 4 channels to reuse the same thing and not worry about hardware changes.

@jairaj-arava jairaj-arava force-pushed the tplg2_mtl_multiple_capture branch 2 times, most recently from 2b25f46 to bd6c69f Compare February 16, 2023 23:53
@jairaj-arava jairaj-arava force-pushed the tplg2_mtl_multiple_capture branch from bd6c69f to d50a295 Compare February 17, 2023 00:43
@ranj063
Copy link
Collaborator

ranj063 commented Feb 17, 2023

@jairaj-arava can you please have a look at the change in #7113? We are switching to using arrays and I'd like all new changes to follow that

@kv2019i
Copy link
Collaborator

kv2019i commented Feb 17, 2023

@jairaj-arava array-support merged in #7113 so rebase will be needed

@jairaj-arava
Copy link
Contributor Author

@jairaj-arava array-support merged in #7113 so rebase will be needed

@ranj063 and @kv2019i
Sure, I willl check on it.

@jairaj-arava jairaj-arava force-pushed the tplg2_mtl_multiple_capture branch from d50a295 to d853fdc Compare February 17, 2023 23:48
@jairaj-arava
Copy link
Contributor Author

@jairaj-arava can you please have a look at the change in #7113? We are switching to using arrays and I'd like all new changes to follow that

@ranj063 @kv2019i , submitted the changes as suggested.

@jairaj-arava jairaj-arava force-pushed the tplg2_mtl_multiple_capture branch from d853fdc to 15e6e3d Compare February 18, 2023 01:55
This patch adds second capture stream by means of copier module

Signed-off-by: jairaj-arava <jairaj.arava@intel.com>
@gkbldcig
Copy link
Collaborator

Can one of the admins verify this patch?

@kv2019i
Copy link
Collaborator

kv2019i commented Feb 20, 2023

One DUT not run in https://sof-ci.01.org/sofpr/PR7085/build4015/devicetest/index.html test, but not relevant for this PR, so proceeding with merge.

@kv2019i kv2019i merged commit d85d853 into thesofproject:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants