Remove legacy Intel platforms #7000

lyakh · 2023-01-27T15:37:28Z

No description provided.

plbossart · 2023-01-27T15:52:48Z

scripts/docker_build/sof_builder/Dockerfile

can we also remove hsw please? It was never supported...

plbossart · 2023-01-27T15:53:41Z

scripts/qemu-check.sh

and remove bdw as well btw.

skl kbl are also questionable now that I read the whole line

lyakh · 2023-01-27T16:03:27Z

@plbossart this is just the first step, more to come

fredoh9 · 2023-01-27T17:17:43Z

Thank you for the update. Yesterday I updated SOF Docker image, every platform has 15-20min build time. It will save the build time a lot.

marc-hb · 2023-01-27T20:04:48Z

Thank you for the update. Yesterday I updated SOF Docker image, every platform has 15-20min build time. It will save the build time a lot.

You're talking about the toolchains, right?

installer/GNUmakefile has always been building all platforms in parallel in a couple minutes on my not very fast workstations.

lyakh · 2023-01-30T14:46:24Z

There are some scripts / tests that don't contain Intel platforms newer than cAVS2.0, i.e. after we complete legacy clean up they won't contain any Intel hardware. Do we need those scripts or are they deprecated? Those that I've found are:

scripts/qemu-check.sh
scripts/docker_build/sof_builder/Dockerfile
tools/fuzzer

Then there's the tone generator, the test for which is configured for Baytrail

tools/test/topology/test-tone-playback.m4

And one more test set is using an Apollo Lake configuration

tools/test/topology

lyakh · 2023-01-31T15:35:35Z

some statistics:

sof$ git diff HEAD~6 --stat | grep "files changed"
 342 files changed, 84 insertions(+), 40092 deletions(-)

lyakh · 2023-01-31T15:50:47Z

"merge commit" only to resolve a conflict to run CI jobs, will be rebased properly before upstreaming of course

kv2019i

Wow, that is a thorough job (and a lot to review). A few minor notes. As a generic comment, I'd like to see a "supported in stable-v2.2" series comment in all the commits to give some more hints on what this is about.

kv2019i · 2023-01-31T20:23:12Z

src/platform/Kconfig

Would be good to add a mention that these platforms will be supported in the stable-v2.2 branch.

kv2019i · 2023-01-31T20:25:23Z

installer/GNUmakefile

I wonder if we could start with one platform and get the merged. This is getting bewildering to review. Here it seems we are adding back support in middle of the series.

It's a comment. It's true, I wanted to move it back to not remove them in the first place, but forgot. It has a comment in line 26 that these are the platforms kept in 2.3, so no reason to remove them

kv2019i · 2023-01-31T20:28:22Z

tools/coredumper/sof-coredump-reader.py

I can see why you are doing this, but this is bumping up the review effort. I'm mentally scanning for changes that only cover platforms, so this kind of stuff jumps out.

it is related to this patch - it removes "sue" ;-) Obviously, that's why I hit this and other typos fixed in this PR, personally I'd keep these changes - they are tiny and obvious comments, but can trivially be extracted too...

kv2019i · 2023-01-31T20:33:09Z

.travis.yml

After whole series applied, "icl" is still left here.

Don't touch .travis.yml, it has not been used since we moved to Github Actions. There's another PR to finalize the transfer to Github Actions and remove it.

marc-hb · 2023-01-31T21:44:22Z

I wonder if we could start with one platform and get the merged. This is getting bewildering to review.

Agree 200%, it's hard to merely scroll up and down. Focus on one or two platforms to set a template, ease the review pain and give all various CIs time to adjust: they should be able to remove all deprecated platforms with a small number of changed lines. Most of this has been done already.

After the first removal is merged and CI back to normal then removing all the other ones should be easy and require barely any review.

lyakh · 2023-02-01T13:28:35Z

I wonder if we could start with one platform and get the merged. This is getting bewildering to review.

Agree 200%, it's hard to merely scroll up and down. Focus on one or two platforms to set a template, ease the review pain and give all various CIs time to adjust: they should be able to remove all deprecated platforms with a small number of changed lines. Most of this has been done already.

After the first removal is merged and CI back to normal then removing all the other ones should be easy and require barely any review.

we can merge them individually, sure, but that won't make them or the review effort smaller. To avoid redundant reviewing, if after reviewing one of them you notice something that you think is likely to repeat in other patches you can just comment that and stop reviewing. But really, there isn't much to review here. Most of these changes are removing complete files and directories.

marc-hb · 2023-02-01T19:33:42Z

we can merge them individually, sure, but that won't make them or the review effort smaller.

Not each platform individually. Just one platform first, properly reviewed thanks to a reasonable size and nothing off-topic, then well tested in all CIs over a few days after merge.

Then mass duplication to all the other platforms at once in a giant PR that is barely looked at and rubber-stamped.

lgirdwood · 2023-02-02T13:44:56Z

@lyakh can we make this PR byt/cht only as we can see impact of the merge on CI and adjust one by one.

lyakh · 2023-02-03T07:19:38Z

@lyakh can we make this PR byt/cht only as we can see impact of the merge on CI and adjust one by one.

@lgirdwood sure, I'll update it

lgirdwood · 2023-02-10T15:08:28Z

@lyakh its probably a lot easier to split this PR up into one PR per patch above for review and merging and do one by one.

lyakh · 2023-02-13T13:27:12Z

@lyakh its probably a lot easier to split this PR up into one PR per patch above for review and merging and do one by one.

@lgirdwood #7080

Remove all support for Sue Creek platforms, it isn't supported any more. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>

plbossart reviewed Jan 27, 2023

View reviewed changes

scripts/docker_build/sof_builder/Dockerfile Outdated

Copy link

Member

plbossart Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also remove hsw please? It was never supported...

plbossart reviewed Jan 27, 2023

View reviewed changes

kv2019i added this to the v2.5 milestone Jan 27, 2023

lyakh force-pushed the legacy branch 4 times, most recently from 4f3e69f to f200b67 Compare January 31, 2023 15:34

lyakh force-pushed the legacy branch 2 times, most recently from 67280b1 to 05f0dda Compare January 31, 2023 16:15

lyakh marked this pull request as ready for review January 31, 2023 16:24

lyakh requested review from RanderWang, aborisovich, akloniex, dbaluta, lbetlej, lgirdwood, marc-hb, mmaka1 and singalsu as code owners January 31, 2023 16:24

lyakh changed the title ~~[WiP] Remove legacy platforms~~ Remove legacy platforms Jan 31, 2023

kv2019i reviewed Jan 31, 2023

View reviewed changes

lgirdwood changed the title ~~Remove legacy platforms~~ Remove legacy Intel platforms Feb 2, 2023

lyakh mentioned this pull request Feb 7, 2023

Remove byt, cht and bsw platforms from "main" #7053

Merged

lyakh marked this pull request as draft February 7, 2023 16:04

lyakh force-pushed the legacy branch from 05f0dda to 4162638 Compare February 9, 2023 15:59

lyakh marked this pull request as ready for review February 9, 2023 16:00

kv2019i mentioned this pull request Feb 10, 2023

cavs: memory bank powerup flow adjustment #7065

Merged

lyakh marked this pull request as draft February 13, 2023 13:26

platform: remove support for Sue Creek

1ff57b4

Remove all support for Sue Creek platforms, it isn't supported any more. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>

lyakh force-pushed the legacy branch from 4162638 to 1ff57b4 Compare February 20, 2023 13:17

lyakh marked this pull request as ready for review February 20, 2023 13:18

lgirdwood approved these changes Feb 20, 2023

View reviewed changes

lgirdwood merged commit 17fbf7d into thesofproject:main Feb 20, 2023

kv2019i mentioned this pull request Feb 20, 2023

[BUG] sdw loopback test fails on Intel MTL with Zephyr upstream 0c0d73721ed #7132

Closed

lyakh deleted the legacy branch February 21, 2023 07:00

Remove legacy Intel platforms #7000

Remove legacy Intel platforms #7000

Uh oh!

Conversation

lyakh commented Jan 27, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

plbossart Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lyakh commented Jan 27, 2023

Uh oh!

fredoh9 commented Jan 27, 2023

Uh oh!

marc-hb commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lyakh commented Jan 30, 2023

Uh oh!

lyakh commented Jan 31, 2023

Uh oh!

lyakh commented Jan 31, 2023

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc-hb commented Jan 31, 2023

Uh oh!

lyakh commented Feb 1, 2023

Uh oh!

marc-hb commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Feb 2, 2023

Uh oh!

lyakh commented Feb 3, 2023

Uh oh!

lgirdwood commented Feb 10, 2023

Uh oh!

lyakh commented Feb 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

plbossart Jan 27, 2023 •

edited

Loading

marc-hb commented Jan 27, 2023 •

edited

Loading

marc-hb commented Feb 1, 2023 •

edited

Loading