dai-zephyr: handle NULL case when calling dai_config_get() #6897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per interface documentation of dai_config_get(), the function may return NULL if the device is not configured for the requested direction. Handle this case explicitly. Currently no upstream Zephyr driver returns NULL, but e.g. dmic driver returns invalid configuration when dai_config_get() is called with DAI_DIR_TX as direction. Link: thesofproject#6896 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This was referenced Dec 30, 2022
Merged
lyakh
approved these changes
Jan 2, 2023
kv2019i
requested review from
abonislawski,
lgirdwood,
marc-hb,
marcinszkudlinski and
singalsu
marcinszkudlinski
approved these changes
Jan 2, 2023
aiChaoSONG
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per interface documentation of dai_config_get(), the function may return NULL if the device is not configured for the requested direction. Handle this case explicitly.
Currently no upstream Zephyr driver returns NULL, but e.g. dmic driver returns invalid configuration when dai_config_get() is called with DAI_DIR_TX as direction.
Link: #6896
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com