Revert "Audio: Copier: Add missing DMIC DAI index mapping to create_dai()" #6877
Conversation
serhiy-katsyuba-intel
changed the title
|
I think the "fix" would be to extract the least significant 8 bits and use that as dai_index. The node_id can have other bits set in it from kernel side. |
dai_index comes from node_id.f.v_index, it's 8 bit: |
|
yes correct. I'll make the corresponding kernel PR. |
serhiy-katsyuba-intel
force-pushed
the
dmic_revert
branch
from
64c7b12 to
5a6b896
Compare
This reverts commit 8d166a4. This restores working DMIC functionality on Windows platform broken by thesofproject#6668. ATTENTION: This will break DMIC1 (DMIC with DAI index 1) functionality on Linux platform, DMIC0 should still work fine! Non working DMIC1 should be fixed on Linux driver side, not this firmware. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
force-pushed
the
dmic_revert
branch
from
5a6b896 to
2792f0f
Compare
|
@ujfalusi @plbossart fyi - how long has kernel had the wrong ID mapping ? |
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
For me we can go directly with this PR, abi should be used if something needs to be synced
Unfortunately there was no DMIC tests in mtl CI when 6668 merged
serhiy-katsyuba-intel
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Since March 2022. However, the problem affects only DMIC1. DMIC0 works fine with and without #6668. DMIC1 seems was not tested on Linux until recently. |
|
@lgirdwood no I don't think so. I made thesofproject/linux#4114, that should work with this revert. Should be tested however. |
@libinyang Could you please test with this revert and the linux PR from @juimonen. Thanks! |
|
ok, @libinyang pls let us know if this PR and the kernel PR work for you. |
|
@libinyang ping - good to merge ? @mengdonglin fyi. |
|
@libinyang, @lgirdwood good to merge? |
|
@libinyang pls shout if there are any issues and we can address |
8 participants
This reverts commit 8d166a4.
This restores working DMIC functionality on Windows platform broken by #6668.
ATTENTION: This will break DMIC1 (DMIC with DAI index 1) functionality on Linux platform, DMIC0 should still work fine! Non working DMIC1 should be fixed on Linux driver side, not this firmware.
Signed-off-by: Serhiy Katsyuba serhiy.katsyuba@intel.com