[SOF2.4] Backport fixes PR6839, PR6844, PR6846, PR6847 and PR6859 #6866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In user-space tools, memory allocations can reasonably be expected to always succeed. Make this assumption explicit by adding error handling after malloc. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit 4d64893)
In user-space tools, memory allocations can reasonably be expected to always succeed. Make this assumption explicit by adding error handling after calloc. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit 4bec5b2)
The create_dai() function can return an uninitialised value. Fix it by reducing the scope of the variable. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> (cherry picked from commit aff99b2) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
If the main context variable is NULL, it cannot be used to print an error message. Since this actually should never happen, use an assertion similar to other similar cases in the file. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> (cherry picked from commit 10251c5) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This is a theoretical case of an invalid pipeline status, handle it correctly. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> (cherry picked from commit 40e6c1d) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Use a local variable in ipc4_get_buffer() to simplify it and remove redundant code. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> (cherry picked from commit b516172) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
In the lib_manager_dma_deinit() function proper checks for dma_ext structure fields must be added to avoid calling dma api with uninitialized parameters. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com> (cherry picked from commit 4cc849d) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
This patch adds initialization of module_size_ variable in SystemAgent() creator. Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com> (cherry picked from commit 9091635) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
sof-logger -u 115200 -d /lib/firmware/sof-foo.ldc Leads to silent failure as a NULL is passed to open(). Add explicit error handling for this case. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit 80adcdf)
kv2019i
requested review from
akloniex,
bkokoszx,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
requested review from
abonislawski,
jsarha,
jxstelter,
lyakh,
marc-hb and
paulstelian97
| if (dma_ext->dma) { | ||
| dma_put(dma_ext->dma); | ||
| if (dma_ext->dma->z_dev) | ||
| dma_release_channel(dma_ext->dma->z_dev, dma_id); |
Collaborator
There was a problem hiding this comment.
I feel like this is an ordering issue -- is dma_ext->dma even valid after dma_put? I missed this in the original commit I think.
Contributor
There was a problem hiding this comment.
Yes, I think You are right. Thank you for catching this.
paulstelian97
approved these changes
Dec 21, 2022
Collaborator
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
See one inline comment for possible improvement.
lgirdwood
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport following fixes to 2.4: