sof-logger: print error if -u uart option is given with no infile #6846
Conversation
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
I'm surprised this is in here in the first place. There may be another place to check this but here is good too and should be no issue.
|
Oh actually maybe a warning that e.g. the uart isn't used and the regular etrace/DMA trace file is being read instead could be good? Since you're not aborting the program... |
tools/logger/logger.c
Outdated
There was a problem hiding this comment.
| fprintf(stderr, "error: Input file not specified with -u option\n"); | |
| fprintf(stderr, "error: Input file not specified with -i option\n"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
@marc-hb Sorry, I didn't you had a different issue. Ok, I'll rephrase that message.
|
@paulstelian97 wrote:
....a bit of surprise (to me as well), but usage() actually calls exit, so the program does exit here. |
tools/logger/logger.c
Outdated
There was a problem hiding this comment.
sof-logger -u 115200 -d /lib/firmware/sof-foo.ldc Leads to silent failure as a NULL is passed to open(). Add explicit error handling for this case. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202212-soflogger-uart-fix
branch
from
cb4eb34 to
34c8fe3
Compare
|
@marc-hb Now updated. |
6 participants
sof-logger -u 115200 -d /lib/firmware/sof-foo.ldc
Leads to silent failure as a NULL is passed to open(). Add explicit error handling for this case.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com