Convert mixout to use the module adapter #6833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
force-pushed
the
fix/mixout_convert
branch
2 times, most recently
from
d325b3e to
1b3742e
Compare
ranj063
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
ranj063
force-pushed
the
fix/mixout_convert
branch
from
1b3742e to
f47e63d
Compare
ranj063
requested review from
abonislawski,
kv2019i,
lyakh and
serhiy-katsyuba-intel
ranj063
force-pushed
the
fix/mixout_convert
branch
5 times, most recently
from
6256676 to
1c2bb38
Compare
lyakh
reviewed
Dec 19, 2022
Collaborator
There was a problem hiding this comment.
This isn't something introduced or changed by this PR, but this might bight us at some point. This code does
source_c = buffer_acquire(source);
mod_source_info = module_source_info_acquire(mod->source_info);
sink_c = buffer_acquire(sink);
So far with no cross-core linking these just convert between cached and uncached addresses. But when we enable that, this can translate to up to 3 nested locks. And I'm not sure they're taken in the same order everywhere...
Collaborator
Author
Introduce struct module_source_info that will be used to keep track of all the source modules that are bound to a module. Also, add a new field, source_info in struct processing_module to save the source information for each module. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add module_source_info_acquire/release() for coherent access to the module's source_info data. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Define the bind/unbind comp driver ops for the module_adapter which will be used to update the source device pointers in the source_info table. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
When module_reset() returns a non-zero value, print an error if needed and return immediately. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
The check for status counts for modules with multiple sources is only applicable for IPC3. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Initialize the hw_params to 0 before passing it to the individual components in the pipeline. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Convert the mixout module to use the module adapter. The bind/unbind/get_attribute ops in the mixout module have been moved to the module_adapter ops and is functionally the same as with the comp_drv ops. The struct mixout_data struct has been simplified to contain 2 fields as the source info table has been moved to struct processing_module and rename the consumed_yet_not_produced_frames field in struct mixout_data to pending_frames. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/mixout_convert
branch
from
1c2bb38 to
6dad788
Compare
singalsu
approved these changes
Dec 20, 2022
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Looks OK to me with disclaimer that I don't know really about coherent and IPC4.
lgirdwood
approved these changes
Dec 20, 2022
Collaborator
|
FYI @serhiy-katsyuba-intel please check. This was already merged, but you had comments to previous PR on this topic. |
Contributor
|
@kv2019i , I do not see any problems now, yet it's not easy to review -- big change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.