Any idea why MTL does not build? https://github.com/thesofproject/sof/actions/runs/3650616164/jobs/6166821755

EDIT: probably a toolchain issue.

Hang on - sof-logger will still be used by xtos users. Needs to be reverted unless this is now in a tools repo. @marcinszkudlinski @aborisovich any comments ?

Ok, I understand but this tool is not needed for the release of MTL. We are going to fix vulnerabilities on SOF main later right @marcinszkudlinski ? Static analysis issues was the only reason we removed it.

Wait a second we are still heavily using sof-logger. What is the alternative for it? Or what's the plan here?

this relase is for mtl-zephyr only. Mtrace python script should be used there.
As security fix was a little problematic and time is very short, we just removed binary that is not a part of the release. Main branch, of course, requires a valid fix.

This PR was merged with a single approval. Yes, it was merged in a feature branch rather than the main one, but I do feel it was a rush job, which I believe should raise some red flags about how things are done. Honestly.

This, plus the incident from yesterday... Who is demanding that static analysis tools are to be obeyed with such an urgency that proper review is skipped, even if it's strictly for a platform-specific branch?

This PR was merged with a single approval. Yes, it was merged in a feature branch rather than the main one, but I do feel it was a rush job, which I believe should raise some red flags about how things are done. Honestly.

This, plus the incident from yesterday... Who is demanding that static analysis tools are to be obeyed with such an urgency that proper review is skipped, even if it's strictly for a platform-specific branch?

That's a good point - on Intel side we are working out how we can do a more frequent scan with static analysis tools and how this can be more automated and frequent. We still need to work quite a few things out. Unfortunately the tooling is very manual and cumbersome atm and this was a work item for this sprint. We are working to improve this though, but this sounds like a good topic for next TSC as its for everyone's benefit.

Wait a second we are still heavily using sof-logger.

@dbaluta there was at least one a couple obvious bugs reported in #6738, would you mind fixing them in the main branch? We stopped using sof-logger in the main branch.