topology2: add deepbuffer to nocodec #6508

RanderWang · 2022-10-31T09:02:24Z

No description provided.

tools/topology/topology2/cavs/cavs-mixin-mixout-hda.conf

tools/topology/topology2/cavs/platform/intel/deep-buffer.conf

RanderWang · 2022-11-01T02:48:02Z

updated. Validated each tplg file and tested sdw on device.

lgirdwood · 2022-11-01T16:30:31Z

@RanderWang conflicts.

RanderWang · 2022-11-02T02:57:11Z

@lgirdwood conflict was caused by chain dma. please first merge #6514.

RanderWang · 2022-11-04T09:16:21Z

@lgirdwood conflict fixed

plbossart

mostly good but this needs serious polish to make it shiny clean

tools/topology/topology2/cavs/platform/intel/deep-buffer.conf

tools/topology/topology2/cavs/cavs-nocodec.conf

tools/topology/topology2/cavs/cavs-sdw.conf

tools/topology/topology2/cavs/CMakeLists.txt

plbossart

I'd like the deep-buffer size to be configurable per product. There's no good reason to force everyone to use 100ms upfront.

plbossart · 2022-11-09T15:44:08Z

Actually rebase necessary @RanderWang, looks like there are conflicts?

We should also check why we have two TIMEOUTS on 2 out of 3 nocodec test devices. it's a troubling coincidence, isn't it?

tools/topology/topology2/cavs/CMakeLists.txt

RanderWang · 2022-11-15T02:10:55Z

SOFCI TEST

RanderWang · 2022-11-15T05:04:21Z

@lgirdwood all ipc4 test pass now

plbossart

#6576

Let's try to use the same indices for PCMs so that the external view of the topology remains the same.

tools/topology/topology2/cavs/cavs-sdw.conf

tools/topology/topology2/cavs/cavs-mixin-mixout-hda.conf

RanderWang · 2022-11-16T02:12:24Z

update deep buffer pcm index to 31 according to topology1

PCM30  playback	LowLatency
PCM31  playback	DeepBuffer (for low-power)
PCM32  playback	Media (e.g. movies)
PCM33  playback	Voice (Communication with a human)
PCM34  playback	Ultrasonics
```

plbossart · 2022-11-16T14:42:17Z

except that we didn't follow the convention for all cases in topology1. We should probably update this for compatibility, it has no impact on UCM/users since it's a developer-only config. Can you do this with a follow-up patch @RanderWang ?

card 0: sofnocodec [sof-nocodec], device 3: Port0 Deep Buffer (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0

plbossart

this looks good but two issues to be aware of before merging @lgirdwood

a) this will conflict with @ranj063 cleanup patch #6592
b) adding a 100ms buffer in the firmware is likely to expose some issues, I would run a daily test on this PR to avoid breaking CI too much.

lgirdwood · 2022-11-16T17:00:00Z

@mengdonglin can we schedule a daily test for this PR as requested by @plbossart ? (can be next week, we can merge the cleanup #6592 first)

ranj063 · 2022-12-01T17:50:14Z

@RanderWang good for rebase now

ranj063 · 2022-12-02T06:23:54Z

@RanderWang let us know the results of the daily test with this PR

RanderWang · 2022-12-02T08:51:19Z

@RanderWang let us know the results of the daily test with this PR

sure, I sent the status to you

lgirdwood · 2022-12-02T15:35:19Z

@RanderWang @ranj063 pls let me know when ready to merge.

lgirdwood · 2022-12-02T15:35:36Z

@RanderWang conflicts

It will be shared by I2S, HDA and SDW platforms Signed-off-by: Rander Wang <rander.wang@intel.com>

Deep buffer is mixed with ssp0 stream. Signed-off-by: Rander Wang <rander.wang@intel.com>

Deep buffer is mixed with Jack out. Signed-off-by: Rander Wang <rander.wang@intel.com>

Deep buffer is mixed with HDA analog. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang · 2022-12-05T10:01:55Z

@lgirdwood updated. Now it passes all ipc4 test on TGL, but some cases are failed on MTL for power management issue

marc-hb · 2022-12-07T07:14:47Z

Could this PR cause this recent TGL IPC4 regression?

[BUG] [TGL] runtime-pm-status: dsp is not suspended after 15s, end test #6735

It's the only significant PR that was merged recently.

RanderWang · 2022-12-07T08:49:40Z

I triggered a test plan in ci 18496, check-kmod-load-unload-after-playback passed. Maybe it can result to this bug but it should be in low rate. It will enabled D0i3 if only deepbuffer stream is working.

marc-hb · 2022-12-07T09:47:23Z

it's a fairly high rate:

[BUG] [TGL] runtime-pm-status: dsp is not suspended after 15s, end test #6735 (comment)

RanderWang requested review from dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart as code owners October 31, 2022 09:02

RanderWang requested review from bardliao and ranj063 October 31, 2022 09:03

RanderWang force-pushed the ipc4-deepbuffer branch from fe21cea to 533a9d3 Compare October 31, 2022 11:53

ranj063 reviewed Oct 31, 2022

View reviewed changes

tools/topology/topology2/cavs/cavs-mixin-mixout-hda.conf Outdated Show resolved Hide resolved

ranj063 reviewed Oct 31, 2022

View reviewed changes

tools/topology/topology2/cavs/platform/intel/deep-buffer.conf Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-deepbuffer branch from 533a9d3 to 5d59951 Compare November 1, 2022 02:09

RanderWang requested review from aborisovich and marc-hb as code owners November 1, 2022 02:09

RanderWang removed request for aborisovich and marc-hb November 1, 2022 02:30

ranj063 approved these changes Nov 1, 2022

View reviewed changes

lgirdwood approved these changes Nov 1, 2022

View reviewed changes

RanderWang force-pushed the ipc4-deepbuffer branch 2 times, most recently from 2fe3c0b to a5ff23b Compare November 2, 2022 02:56

RanderWang requested a review from marcinszkudlinski as a code owner November 2, 2022 02:56

RanderWang removed the request for review from marcinszkudlinski November 2, 2022 02:57

RanderWang force-pushed the ipc4-deepbuffer branch from a5ff23b to dcba930 Compare November 3, 2022 01:08

lgirdwood approved these changes Nov 4, 2022

View reviewed changes

plbossart requested changes Nov 4, 2022

View reviewed changes

RanderWang force-pushed the ipc4-deepbuffer branch from dcba930 to 9c88102 Compare November 7, 2022 07:10

plbossart requested changes Nov 7, 2022

View reviewed changes

ranj063 reviewed Nov 9, 2022

View reviewed changes

tools/topology/topology2/cavs/CMakeLists.txt Outdated Show resolved Hide resolved

plbossart requested changes Nov 15, 2022

View reviewed changes

tools/topology/topology2/cavs/cavs-sdw.conf Outdated Show resolved Hide resolved

tools/topology/topology2/cavs/cavs-mixin-mixout-hda.conf Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-deepbuffer branch from 62e1d68 to 912177e Compare November 16, 2022 02:08

plbossart approved these changes Nov 16, 2022

View reviewed changes

RanderWang force-pushed the ipc4-deepbuffer branch 2 times, most recently from e023252 to decfc9c Compare December 2, 2022 05:38

RanderWang mentioned this pull request Dec 5, 2022

pulse audio not detecting sound card (MTL,HDA) thesofproject/linux#4068

Closed

RanderWang added 4 commits December 5, 2022 13:03

topology2: add common deep buffer support

ee5fb3e

It will be shared by I2S, HDA and SDW platforms Signed-off-by: Rander Wang <rander.wang@intel.com>

topology2: nocodec: add deep buffer support

9fa88b5

Deep buffer is mixed with ssp0 stream. Signed-off-by: Rander Wang <rander.wang@intel.com>

topology2: sdw: share the deep buffer conf setting

6e10ea9

Deep buffer is mixed with Jack out. Signed-off-by: Rander Wang <rander.wang@intel.com>

topology2: hda: share deep buffer conf setting

a0a365a

Deep buffer is mixed with HDA analog. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang force-pushed the ipc4-deepbuffer branch from decfc9c to a0a365a Compare December 5, 2022 05:13

lgirdwood approved these changes Dec 5, 2022

View reviewed changes

lgirdwood merged commit 8818e50 into thesofproject:main Dec 5, 2022

marc-hb mentioned this pull request Dec 7, 2022

[BUG] [TGL] runtime-pm-status: dsp is not suspended after 15s, end test #6735

Closed

topology2: add deepbuffer to nocodec #6508

topology2: add deepbuffer to nocodec #6508

Uh oh!

Conversation

RanderWang commented Oct 31, 2022

Uh oh!

Uh oh!

Uh oh!

RanderWang commented Nov 1, 2022

Uh oh!

lgirdwood commented Nov 1, 2022

Uh oh!

RanderWang commented Nov 2, 2022

Uh oh!

RanderWang commented Nov 4, 2022

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

plbossart commented Nov 9, 2022

Uh oh!

Uh oh!

RanderWang commented Nov 15, 2022

Uh oh!

RanderWang commented Nov 15, 2022

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RanderWang commented Nov 16, 2022

Uh oh!

plbossart commented Nov 16, 2022

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Nov 16, 2022

Uh oh!

ranj063 commented Dec 1, 2022

Uh oh!

ranj063 commented Dec 2, 2022

Uh oh!

RanderWang commented Dec 2, 2022

Uh oh!

lgirdwood commented Dec 2, 2022

Uh oh!

lgirdwood commented Dec 2, 2022

Uh oh!

RanderWang commented Dec 5, 2022

Uh oh!

marc-hb commented Dec 7, 2022

Uh oh!

RanderWang commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented Dec 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RanderWang commented Dec 7, 2022 •

edited

Loading