ipc4: add S24_3LE for ipc4 #5198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
reviewed
Jan 12, 2022
ranj063
reviewed
Jan 13, 2022
Collaborator
Author
|
updated, thanks! |
singalsu
requested changes
Jan 13, 2022
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
The s24c32 without sign extend is a risk, better to fix it.
singalsu
reviewed
Jan 13, 2022
RanderWang
force-pushed
the
s24_3le
branch
4 times, most recently
from
ea792a0 to
1435ef8
Compare
Member
|
@singalsu good for you ? |
The src & sink info can be gotten from struct comp_copy_limits, no need to calculate it again. Signed-off-by: Rander Wang <rander.wang@intel.com>
Move endif to include general ipc4 conversion. Signed-off-by: Rander Wang <rander.wang@intel.com>
Compared to non-copier module, copier module uses different conversion algorithoms for different gateways, .e.g HDA dma requires sample bit starting from MSB bits and also alh engine. These hw features make pcm conversion algorithom different for different modules. This patch add gateway type to select conversion function. Signed-off-by: Rander Wang <rander.wang@intel.com>
First we reused ipc3 pcm conversion function by by setting frame_fmt to S24_4LE, but later found that we need different conversion for copier with gateways support. Now frame_fmt will be set by default config. Signed-off-by: Rander Wang <rander.wang@intel.com>
For HDA gateway, 24bits sample will be in high 24bits with 32 bits container case. Alh requires 32 bits container and all sample bits starting from bit 31 to bit 0. Signed-off-by: Rander Wang <rander.wang@intel.com>
S24_3LE is not a native supported format for hda dma. Driver treats it as 16bit stream or 8bit stream, .e.g. 24bit 3LE 2ch stream will be set as 16bit 3ch stream. In FW side, 24bit stream will be converted to S24LE. Currently HIFI3 optimization is not supported now and also S24_LE unit test is not implemented. These will be supported later. Tested on windows platform. Signed-off-by: Rander Wang <rander.wang@intel.com>
Collaborator
Author
|
updated, thanks |
singalsu
approved these changes
Jan 19, 2022
lyakh
reviewed
Jan 20, 2022
Contributor
lgirdwood
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S24_3LE is not a native supported format for hda dma. Driver
treats it as 16bit stream or 8bit stream, .e.g. 24bit 3LE
2ch stream will be set as 16bit 3ch stream. In FW side,
24bit stream will be converted to S24LE.