Modify RTNR macro for TGL and ADL #5010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove DMICPROC and DMIC16KPROC for RTNR macro. Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
MingJenTai
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
MingJenTai
force-pushed
the
main_3_Modify_RTNR_Macro_for_TGL_and_ADL
branch
from
814474e to
748f940
Compare
lgirdwood
approved these changes
Nov 23, 2021
macchian
requested changes
Nov 30, 2021
| "sof-tgl-max98357a-rt5682\;sof-tgl-max98357a-rt5682\;-DCODEC=MAX98357A\;-DFMT=s16le\;-DPLATFORM=tgl\;-DAMP_SSP=1" | ||
| "sof-tgl-max98357a-rt5682\;sof-adl-max98357a-rt5682\;-DCODEC=MAX98357A\;-DFMT=s16le\;-DPLATFORM=adl\;-DAMP_SSP=2" | ||
| "sof-tgl-max98357a-rt5682\;sof-adl-max98357a-rt5682-rtnr\;-DCODEC=MAX98357A\;-DFMT=s16le\;-DPLATFORM=adl\;-DAMP_SSP=2\;-DCHANNELS=2\;-DDMICPROC=eq-iir-volume\;-DRTNR" | ||
| "sof-tgl-max98357a-rt5682\;sof-adl-max98357a-rt5682-rtnr\;-DCODEC=MAX98357A\;-DFMT=s16le\;-DPLATFORM=adl\;-DAMP_SSP=2\;-DCHANNELS=2\;-DRTNR" |
Contributor
There was a problem hiding this comment.
@MingJenTai , because this PR has a delete file, it is not easy to re-apply it to others.
I think moving previous old RTNR relevant settings(eq-iir-volume...) and deleted sof-tgl-max98357a-rt5682-rtnr-16kHz.m4 to PR #5009. (It's more like a reverting your previous applied).
In this PR, only remain the RTNR macro enabled. How do you think?
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits: