topology: Modify RTNR to work with KWD on TGL and ADL. #4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify RTNR to work with KWD on TGL and ADL. Remove unused RTNR 16kHz topology. Add RTNR support to max98390 on ADL. Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
MingJenTai
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
reviewed
Nov 15, 2021
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks like this needs to be 3 patches since the commit message say we are doing 3 different things.
@macchian @plbossart any comments. ?
Contributor
@lgirdwood , same thoughts. |
Contributor
Author
|
Hi, @lgirdwood and @macchian thanks for the opinion. I created 3 separate PRs to make it clearer. Please review them instead, thank you! |
lgirdwood
approved these changes
Nov 23, 2021
Member
|
Zephyr build failure already fixed. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies RTNR to work with KWD on TGL and ADL, and removes unused RTNR 16kHz topology.
It also adds RTNR support to max98390 on ADL.