Cherry-pick RTNR commits from main branch to adl-003-drop-stable #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds RTNR Noise Reduction/Suppression(NR/NS) component by Realtek Semiconductor Corp. This feature links to proprietary libraries. Please contact antz0525@realtek.com for any question about the library. Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> Cherry-picked from bbc5209, with the following changes: Move files added under tools/topology/topology1/ to tools/topology/ Migrate changes in tools/topology/topology1/CMakeLists.txt to tools/topology/CMakeLists.txt Modify rtnr_new() in rtnr.c in accordance with API changes.
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> Cherry-picked ffrom a226f0b
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> Cherry-picked from d3381ea, with following changes: Migrate changes in tools/topology/topology1/CMakeLists.txt to tools/topology/CMakeLists.txt Migrate changes in tools/topology/topology1/sof-tgl-max98357a-rt5682.m4 to tools/topology/sof-tgl-max98357a-rt5682.m4
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> Cherry-picked from e4e23d4, with the following changes: Migrate changes in tools/topology/topology1/CMakeLists.txt to tools/topology/CMakeLists.txt
Add 48kHz recording support to RTNR Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> Cherry-picked from bf1e3b7, with the following changes: Migrate modifications under tools/topology/topology1/ to an upper level.
MingJenTai
requested review from
a team,
dbaluta,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
Contributor
|
Thanks for the update, FYI, you can add the cherry picked from tag with the |
cujomalainey
approved these changes
Nov 3, 2021
mwasko
approved these changes
Nov 4, 2021
cujomalainey
reviewed
Nov 9, 2021
| `ifdef(`DMIC16KPROC', , `define(DMIC16KPROC, eq-iir-volume)')') | ||
|
|
||
| # include the generic dmic if RTNR is defined, else include generic dmic with kwd | ||
| include(ifdef(`RTNR', platform/intel/intel-generic-dmic.m4, platform/intel/intel-generic-dmic-kwd.m4)) |
Contributor
There was a problem hiding this comment.
i missed this in my initial review, @MingJenTai this wont work. You simply can't remove hotwording. They both need to work in this config.
Contributor
Author
There was a problem hiding this comment.
@cujomalainey Ok I'll have a fix for that. Thanks.
Contributor
Author
There was a problem hiding this comment.
@cujomalainey I've created PR #4988 for this. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks RTNR commits from main branch to adl-003-drop-stable.
The original commits and modifications are stated in the commit message.