pipeline: remove heap status dumps from pipeline code #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dynamic pipelines, pipelines can be created and destroyed often enough at runtime, which makes dumping heap statue for each such action too noisy. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
requested changes
Sep 10, 2021
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
We need this atm for debug with allocator, I think its a debug option though which you could turn off.
Collaborator
Author
@lgirdwood Don't think I've enabled any additional debug options, I think it's printed in default configuration. But sure, nothing critical. Would just be good to reduce that noise, it's really filling the log when testing quick pipeline start / stop sequences and using up performance |
Contributor
|
maybe we can add condition e.g. |
Member
|
Can one of the admins verify this patch? |
Collaborator
|
@lyakh Still valid? |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dynamic pipelines, pipelines can be created and destroyed often enough at runtime, which makes dumping heap statue for each such action too noisy.