Skip to content

xtensa-build-all: Fix missed $j -> $platform renaming #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Jul 14, 2020
Merged

xtensa-build-all: Fix missed $j -> $platform renaming #3167

lgirdwood merged 1 commit into from
Jul 14, 2020

Conversation

@crazoes
Copy link
Contributor

@crazoes crazoes commented Jul 13, 2020

In renaming of $j -> $platform one instance of variable was missed which
has led to wrong configs being used.

Signed-off-by: Shreeya Patel shreeya.patel23498@gmail.com

@crazoes crazoes requested a review from jajanusz as a code owner July 13, 2020 05:08
@crazoes
Copy link
Contributor Author

crazoes commented Jul 13, 2020

Fixes #2711 (comment) spotted by @marc-hb. Also, sorry about missing this one instance of renaming 😓

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 13, 2020 •
edited
Loading

Considering some of the CI failures in https://sof-ci.01.org/sofpr/PR3167/build6570/devicetest/ are on BYT, I think we need to pay them more attention than usual.

@crazoes can you diff the .config files before vs after this fix and share the diff in a comment here if it's not too big? Thx

marc-hb
marc-hb requested changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For small but potentially impactful fixes like this the commit message is important. Can you please add Fixes: 941dfcccb03 ("use switch case") in the body and change the subject to something more meaningful like: xtensa-build-all: fix gcc _defconfig for byt|cht|cnl|sue. Thx.

sorry about missing this

shellcheck is your friend.

@marc-hb marc-hb requested a review from ranj063 July 13, 2020 06:29
@crazoes crazoes mentioned this pull request Jul 13, 2020
Merged
paulstelian97
paulstelian97 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@paulstelian97 paulstelian97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH came back online :) Also, this change looks good for me.

@crazoes
Copy link
Contributor Author

crazoes commented Jul 13, 2020

CC: @dbaluta

@crazoes
Copy link
Contributor Author

crazoes commented Jul 13, 2020

I've pushed the amended commit however, it does not reflect in github. I pushed it when github was down, maybe they have some processing that failed and hence, not showing up here. 😕

@crazoes
Copy link
Contributor Author

crazoes commented Jul 13, 2020

Will amend again so hash changes

@crazoes crazoes force-pushed the xtensas-build-all-fix branch from aee7ce1 to 5c2a456 Compare July 13, 2020 12:51
@crazoes
xtensa-build-all: fix gcc _defconfig for byt|cht|cnl|sue
5c2a456 
In renaming of $j -> $platform one instance of variable was missed which
has led to wrong configs being used.

Fixes: 941dfcc ("use switch case")

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
@lgirdwood
Copy link
Member

lgirdwood commented Jul 14, 2020

Alsabat CI clipping. @aiChaoSONG Btw - the sof-logger output on BSW/BYT tests does not align to the topology. i.e. I see component IDs 4.20 and 1.6 that are not in topology diagram.

@lgirdwood lgirdwood merged commit d434dbc into thesofproject:master Jul 14, 2020
@crazoes
Copy link
Contributor Author

crazoes commented Jul 14, 2020

Configs prior and post fix and diff between the same - https://gist.github.com/crazoes/f8fd5557ba1d3e418f887a0704a434e5

cc @marc-hb

@marc-hb marc-hb mentioned this pull request Jul 14, 2020
Merged
@aiChaoSONG
Copy link
Collaborator

aiChaoSONG commented Jul 15, 2020 •
edited
Loading

Alsabat CI clipping. @aiChaoSONG Btw - the sof-logger output on BSW/BYT tests does not align to the topology. i.e. I see component IDs 4.20 and 1.6 that are not in topology diagram.

@lgirdwood There are graph section and widget section in the topology binary, right? The graph drawing is from the graph section. As I observed, not all widgets are linked in the graph. Take sof-byt-rt5640.tplg for example, besides the widgets you can see from the graph, there are extra widgets in the widget section: codec_out0, PIPELINE.1.SSP2.OUT, codec_out1, PIPELINE.2.SSP2.IN, codec_in0, PIPELINE.3.SSP2.OUT, codec_in1, ssp2 Rx, ssp2 Tx, ssp0 Tx, ssp0 Rx, modem_out, modem_in

Maybe some legacy m4 need a fix?

@lgirdwood
Copy link
Member

lgirdwood commented Jul 15, 2020

@aiChaoSONG the sof-log showed these as buffers ?

@aiChaoSONG
Copy link
Collaborator

aiChaoSONG commented Jul 16, 2020

@lgirdwood No, they are dumped from binary topology(*.tplg), but seems I couldn't see them from the sof-logger

@1994lwz 1994lwz mentioned this pull request Sep 27, 2021
Closed
@ranj063 ranj063 mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes

@paulstelian97 paulstelian97 paulstelian97 approved these changes

@marc-hb marc-hb marc-hb approved these changes

@jajanusz jajanusz Awaiting requested review from jajanusz

@ranj063 ranj063 Awaiting requested review from ranj063

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crazoes @marc-hb @lgirdwood @aiChaoSONG @dbaluta @paulstelian97