scripts: build-all: warn when ignoring unknown arguments #2625
Conversation
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
I think that this script should be just fixed instead of printing warn.
@lgirdwood Why we manually parse args? Cannot we just use getopt? It's in any okish bash and we focus on supporting ubuntu 16+ afaik, we shouldn't care about some ancient/small distros that don't support pretty standard stuff.
If @lgirdwood is ok with it, then it should be just rewritten with getopt and it will handle cases like -j6 & -j 6.
I don't know about "easily" but in terms of time, number of lines changed and risk of not testing some combination or corner case and breaking it, it would be a completely different order of work magnitude. So no, not really. Totally agree this script shouldn't be re-implementing |
|
Ok, warn is better than nothing, added issue for improvement: #2631 |
Example: $ ./scripts/xtensa-build-all.sh -j3 ./scripts/xtensa-build-all.sh: WARN: ignoring arg -j3 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
build-all-warn-unknown-arg
branch
from
238e5a8 to
019b657
Compare
|
Not CI tested for internal CI, Jenkins known issues. |
At the time this script only "smelled" bad. Now I know it is bad, see PR #2711 |
4 participants
Example:
Signed-off-by: Marc Herbert marc.herbert@intel.com