dai: stop DMA unconditionally on xrun #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops DMA unconditionally on xrun without waiting. Data flush is not needed as pipeline will go through prepare and restart anyway. Waiting here during xrun recovery with multiple tasks running causes interrupt stack overflow. Waiti instruction lowers irq level to 0, which allows to run multiple scheduled tasks in the same time on the same irq level and ends in DSP panic. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Contributor
Author
|
@lgirdwood Updated the stop sequence to match the one, we've been using in cAVS platforms for years. We've been always stopping DMA channels asynchronously and never observed any problems after that. Anyway, I think previously in SOF we've never really stopped DMA channels with empty FIFO, because DMA was running in realtime mode and has never waited for clearing DONE bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops DMA unconditionally on xrun without waiting.
Data flush is not needed as pipeline will go through
prepare and restart anyway. Waiting here during xrun
recovery with multiple tasks running causes interrupt
stack overflow. Waiti instruction lowers irq level to
0, which allows to run multiple scheduled tasks in the
same time on the same irq level and ends in DSP panic.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com