Skip to content

west.yml: update zephyr to 958057176c7#10941

Open
sneha-voona wants to merge 1 commit into
thesofproject:mainfrom
sneha-voona:west-yml-update-hal-xtensa-acp73
Open

west.yml: update zephyr to 958057176c7#10941
sneha-voona wants to merge 1 commit into
thesofproject:mainfrom
sneha-voona:west-yml-update-hal-xtensa-acp73

Conversation

@sneha-voona

@sneha-voona sneha-voona commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Update west.yml to bring hal_xtensa headers in zephyr for AMD ACP 7X.

@sofci

sofci commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@lgirdwood

lgirdwood commented Jun 19, 2026

Copy link
Copy Markdown
Member

@sneha-voona do we need a later west commit ID as its failing on NXP platform AFAICT: @dbaluta fyi.

g/drivers/esai/fsl_esai.c
/__w/sof/sof/modules/hal/nxp/mcux/mcux-sdk-ng/drivers/esai/fsl_esai.c:1242:2: error: #endif without #if
 1242 | #endif
      |  ^~~~~
[297/358] Building C object modules/xtensa/CMakeFiles/modules_xtensa_hal.dir/src/hal/coherence.c.obj
[298/358] Building ASM object modules/xtensa/CMakeFiles/modules_xtensa_hal.dir/src/hal/clock.S.obj
[299/358] Building C object modules/hal_nxp/CMakeFiles/modules__hal_nxp.dir/__w/sof/sof/modules/hal/nxp/mcux/mcux-sdk-ng/drivers/common/fsl_common_dsp.c.obj
[300/358] Building C object modules/hal_nxp/CMakeFiles/modules__hal_nxp.dir/__w/sof/sof/modules/hal/nxp/mcux/mcux-sdk-ng/drivers/edma_rev2/fsl_edma_rev2.c.obj
[301/358] Building C object modules/hal_nxp/CMakeFiles/modules__hal_nxp.dir/__w/sof/sof/modules/hal/nxp/mcux/mcux-sdk-ng/drivers/sai/fsl_sai.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /opt/python/venv/bin/cmake --build /__w/sof/sof/build-imx8
Traceback (most recent call last):
  File "/__w/sof/sof/./sof/scripts/xtensa-build-zephyr.py", line 1419, in <module>
    main()
  File "/__w/sof/sof/./sof/scripts/xtensa-build-zephyr.py", line 1411, in main
    build_platforms()
  File "/__w/sof/sof/./sof/scripts/xtensa-build-zephyr.py", line 1013, in build_platforms
    raise cpe
  File "/__w/sof/sof/./sof/scripts/xtensa-build-zephyr.py", line 1007, in build_platforms
    execute_command(build_cmd, cwd=west_top, env=platf_build_environ, sof_log_env=True)
  File "/__w/sof/sof/./sof/scripts/xtensa-build-zephyr.py", line 488, in execute_command
    return subprocess.run(*run_args, **run_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['west', 'build', '--build-dir', 'build-imx8', '--board', 'imx8qm_mek/mimx8qm6/adsp', '/__w/sof/sof/sof/app', '--', '-DEXTRA_CFLAGS=-Werror', '-DEXTRA_CXXFLAGS=-Werror', '-DEXTRA_AFLAGS=-Werror -Wa,--fatal-warnings', '--warn-uninitialized', '-DEXTRA_CONF_FILE=/__w/sof/sof/sof/app/configs/repro-build.conf']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

@sneha-voona

sneha-voona commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@lgirdwood
The hal_xtensa header changes I needed are also present in newer Zephyr commits.
I can update this to a later commit to see if it fixes the NXP issue—does that sound good to you?

@lgirdwood

lgirdwood commented Jun 23, 2026

Copy link
Copy Markdown
Member

@lgirdwood The hal_xtensa header changes I needed are also present in newer Zephyr commits. I can update this to a later commit to see if it fixes the NXP issue—does that sound good to you?

Yes, it sometimes a bit of trial and error, it could also be that zephyrs own west has not been updated for the NXP hal. @dbaluta any insights here ?

@dbaluta

dbaluta commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@lgirdwood added a fix for this here: zephyrproject-rtos/hal_nxp#755

@sneha-voona It will take few days until it propagates so if updating zephyr to an older hash works for you go ahead.

Later edit: Zephyr PR here: zephyrproject-rtos/zephyr#111877

@lgirdwood

lgirdwood commented Jun 25, 2026

Copy link
Copy Markdown
Member

@lgirdwood added a fix for this here: zephyrproject-rtos/hal_nxp#755

@sneha-voona It will take few days until it propagates so if updating zephyr to an older hash works for you go ahead.

Later edit: Zephyr PR here: zephyrproject-rtos/zephyr#111877

Ok, 1st PR is merged, @sneha-voona lets wait for 2nd PR merging and we can regenerate and merge the west update.

@sneha-voona sneha-voona force-pushed the west-yml-update-hal-xtensa-acp73 branch from 3f97721 to 1307abe Compare June 26, 2026 06:11
@sneha-voona

sneha-voona commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@lgirdwood added a fix for this here: zephyrproject-rtos/hal_nxp#755
@sneha-voona It will take few days until it propagates so if updating zephyr to an older hash works for you go ahead.
Later edit: Zephyr PR here: zephyrproject-rtos/zephyr#111877

Ok, 1st PR is merged, @sneha-voona lets wait for 2nd PR merging and we can regenerate and merge the west update.

@lgirdwood, since both PRs are merged now, I’ve updated west.yml to use the Zephyr commit that includes the fix.

@sneha-voona sneha-voona force-pushed the west-yml-update-hal-xtensa-acp73 branch from 1307abe to 2d86fee Compare June 26, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes
@kv2019i kv2019i kv2019i approved these changes
@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner
@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner
@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner
@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sneha-voona @sofci @lgirdwood @dbaluta @kv2019i