audio: dai: Pass bespoke config size through dai_set_config chain #10373
Conversation
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dai_set_config() function signature to accept and propagate a size parameter for bespoke DAI configuration data, aligning with an updated Zephyr DAI driver API that requires explicit size validation for configuration blobs.
Key Changes:
- Added
size_t sizeparameter todai_set_config()function signature across the codebase - Updated the function call in IPC4 dai_config() to pass
copier_cfg->gtw_cfg.config_lengthas the size argument - Forwarded the size parameter to the underlying
dai_config_set()Zephyr driver API call
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ipc/ipc4/dai.c | Updated dai_set_config() call to include config_length parameter |
| src/include/sof/lib/dai-zephyr.h | Added size parameter to dai_set_config() function declaration |
| src/audio/dai-zephyr.c | Updated dai_set_config() implementation to accept and forward size parameter to dai_config_set() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
you could update west.yml to point to that Zephyr PR and to run tests with it
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Change is good, but I'll mark with DNM until the Zephyr dependency is met.
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
Very good change! (●'◡'●)
|
@abonislawski can you check CI thanks ! |
|
@lgirdwood Yes, the Zephyr PR is merged, so I need to add a west update here. However, another Zephyr PR also got merged at the same time, so first we need to merge #10173 and then move to this one. |
|
@abonislawski I think this needs to now go next. The Zephyr PR was merged and SOF cannot be updated without the changes in this PR. And to not break bisect, you need to update the Zephyr commit-id in a single git commit with the changes you have here. |
majunkier
left a comment
majunkier
left a comment
There was a problem hiding this comment.
tested locally, fixes issue with error: too few arguments to function 'dai_config_set'
|
Ack @abonislawski , #10173 now merged. |
rerun CI. |
|
SOFCI TEST |
b33fc9a7b2d4 drivers: dai: intel: ssp: Fix SSP blob v3.0 TLV parsing
b038ee72fae2 drivers: dai: Add size parameter to dai_config_set API
552c1514a6c5 drivers: dai: intel: ssp: Add support for
SSP_GTW_DMA_CONFIG_ID TLV type
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Update dai_set_config() to accept and propagate the size parameter for bespoke DAI configuration data, matching the updated Zephyr DAI driver API. Changes: - Add size_t size parameter to dai_set_config() function - Update dai_set_config() signature in dai-zephyr.h header - Pass copier_cfg->gtw_cfg.config_length as size in IPC4 dai_config() - Forward size parameter to dai_config_set() Zephyr driver API call This change completes the integration with the new Zephyr DAI API that requires explicit size validation for bespoke configuration blobs, enabling proper bounds checking in DAI drivers. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
ssp_dai_api_size
branch
2 times, most recently
from
a5ff6f2 to
e16862b
Compare
|
Final zephyr update added, CI should pass now |
7 participants
Update dai_set_config() to accept and propagate the size parameter for bespoke DAI configuration data, matching the updated Zephyr DAI driver API.
Changes:
This change completes the integration with the new Zephyr DAI API that requires explicit size validation for bespoke configuration blobs, enabling proper bounds checking in DAI drivers.
Zephyr PR: