west.yml: update zephyr to e876dee6f2e #10268
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Updates the Zephyr revision in the west.yml manifest file to incorporate 934 commits with improvements across multiple subsystems including power management, LLEXT security, kernel optimization, and driver enhancements.
- Updated Zephyr revision from 5bef4a9d6264761c10d739b345eb2f7ded719099 to 06daf0e29ee1d7cfd8242f45f2ad04f2fd2b03b9
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
f9ec542 to
7f72a38
Compare
|
@kv2019i we have problem with TGL build: 16:10:00,766 INFO - FAILED: modules/sof/CMakeFiles/modules_sof.dir/buildagent/workspace/24733/sof/src/platform/intel/cavs/platform.c.obj
16:10:00,766 INFO - ccache /root/xtensa/XtDevTools/install/tools/RG-2017.8-linux/XtensaTools/bin/xt-xcc -DCC_OPTIMIZE_FLAGS=\"\" -DKERNEL -DK_HEAP_MEM_POOL_SIZE=8192 -DXCC_TOOLS_VERSION=\"xcc\" -D__ZEPHYR__=1 -DRELATIVE_FILE=\"../sof/src/platform/intel/cavs/platform.c\" -I/buildagent/workspace/24733/build-tgl/zephyr/include/generated/zephyr -I/buildagent/workspace/24733/zephyr/include -I/buildagent/workspace/24733/build-tgl/zephyr/include/generated -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp/common -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp/common/include -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp/cavs -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp/cavs/include -I/buildagent/workspace/24733/zephyr/soc/intel/intel_adsp/cavs/include/cavs25 -I/buildagent/workspace/24733/zephyr/drivers -I/buildagent/workspace/24733/sof/zephyr/include -I/buildagent/workspace/24733/zephyr/kernel/include -I/buildagent/workspace/24733/zeph...
16:10:00,767 INFO - /buildagent/workspace/24733/sof/src/platform/intel/cavs/platform.c:111: error: unknown field ‘state_exit’ specified in initializer
16:10:00,767 INFO - /buildagent/workspace/24733/sof/src/platform/intel/cavs/platform.c:111: warning: missing braces around initializer
16:10:00,767 INFO - /buildagent/workspace/24733/sof/src/platform/intel/cavs/platform.c:111: warning: (near initialization for ‘pm_state_notifier._node’)
16:10:00,768 INFO - /buildagent/workspace/24733/sof/src/platform/intel/cavs/platform.c:111: warning: initialization from incompatible pointer type |
|
Aa, right, also caught by the public Jenkins CI build: https://sof-ci.01.org/sofpr/PR10268/build16186/build/firmware_community/tgl.log |
@tmleman looks localized to that platform, can you prepend the build fix to this PR. Thanks ! |
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
The newer Zephyr version includes important fixes for llext.
|
@tmleman @softwarecki Would you considering updating the west.yml zephyr hash to also include this change: Or we should merge it as it is and I'll send a seperate update later? |
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
3 times, most recently
from
f5112eb to
15b8fcd
Compare
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
15b8fcd to
78eee5a
Compare
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
78eee5a to
830ce2b
Compare
|
@dbaluta I updated the manifest to include the specified fix. |
|
@tmleman thanks! |
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
830ce2b to
0b14dd7
Compare
|
Update, I placed the wrong hash in the manifest. |
|
Now at least the xt-xcc build goes through, but something wrong still with Intel Internal CI... |
@kv2019i did your xt-xcc build failed too due to Zephyr commit? Is there a problem with CI infra or with failing tests? @lgirdwood we should update Zephyr hash weekly to avoid situations were we pull thousands of zephyr commits. |
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
0b14dd7 to
f67a220
Compare
|
@lgirdwood @dbaluta I had to reduce the scope of the update. A regression appeared, possibly even two:
|
|
@tmleman so is this working? Can you bisect the faulty commit? |
Good question, I think this just means a smaller bisect, but still needs the effort to debug. It could be easiest to add more ztests upstream into Zephyr per platform to help reduce issues (obviously wont catch PM/IP issues but may catch llext and other generic features). |
tmleman
force-pushed
the
topic/upstream/pr/zephyr/upgrade/25ww40
branch
from
f67a220 to
6edc2af
Compare
tmleman
changed the title
|
@kv2019i I updated the manifest to the last working version. So far, only the issue with AEC has been resolved. The test has been removed from CI, and the fix is under review (#10309). @dbaluta unfortunately, I can't update to the version with the fix you're interested in yet. I want this PR to be merged, and then I'll make another update after resolving the remaining issues. |
|
@tmleman no worries. For our current release we create the imx-stable branch and we can handle it there. Hopefully main can be fixed in the couple of next weeks when we restart testing it. |
Total of 976 commits.
Changes include:
a4225b1ee8b pm: Add constraint lists and APIs
ae1f13149fc pm: Extend pm notifier to be able to report substate
823c519db22 subsys/llext: Fail if section name index is outside
strings area
2bc84dc6d62 subsys/llext: Fail if symbol name index is outside
strings area
3f6734034a7 subsys/llext: Fail if stated symbol size doesn't fit
`elf_sym_t`
c6b6c62c21b arch: xtensa: (cosmetic) simplify function prototypes
5c5e17f0f37 kernel: dynamic: Optimize stack pool usage
8658ce5c9ef drivers: dma: dw: Add power management state check
in get_status
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
5 participants
Total of
1426453976 commits.Changes include:
54545430e46 drivers: sai: Fix compile time error with clang96d654bbc86 west.yml: Update hal_xtensa revisioncf7e2e63c17 soc: intel_adsp: rework host IPC using IPC serviced910306fd00 soc: intel_adsp: remove IDC dt default for CONFIG_INTEL_ADSP_IPC0b3b6f30a3d ipm: remove the Intel Audio DSP CAVS host IPM drivera4225b1ee8b pm: Add constraint lists and APIs
ae1f13149fc pm: Extend pm notifier to be able to report substate
823c519db22 subsys/llext: Fail if section name index is outside strings area
2bc84dc6d62 subsys/llext: Fail if symbol name index is outside strings area
3f6734034a7 subsys/llext: Fail if stated symbol size doesn't fit
elf_sym_tc6b6c62c21b arch: xtensa: (cosmetic) simplify function prototypes
5c5e17f0f37 kernel: dynamic: Optimize stack pool usage
8658ce5c9ef drivers: dma: dw: Add power management state check in get_status