Module api rest of the modules #10195

jsarha · 2025-08-26T19:15:18Z

Modules ASRC, Aria, Copier, crossover, multiband_drc, and DRC were aready once reviewed as part of #10164 .

lgirdwood · 2025-09-04T10:01:14Z

src/audio/module_adapter/module/generic.c

 	else
-		ptr = rballoc(SOF_MEM_FLAG_USER, size);
+		ptr = rmalloc(SOF_MEM_FLAG_USER, size);


Should we also rmalloc_aligned() above for rballoc_aligned()

That is a good question. Pretty much the same as should we use virtual heap in the modules at all? There were some rballoc_aligned() calls in the modules, but I do not recall any rmalloc_aligned() calls.

And there is a reason for that. There is no rmalloc_aligned() at the moment. I can of cource easily create one in zephyr/lib/alloc.c and follow the pattern that call is alway forwarded to zephyr system heap. Should I take that route?

I created rmalloc_align() and took that into use.

jsarha · 2025-09-05T08:38:09Z

Please let me know if you want me to split this into multiple PRs.

Convert auditory, dct, fft, and matrix math tests to use module heap API functions instead of the old version using rmalloc() and friends directly. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Both unit tests and modules should now use the module API heap allocation functions, so we can now remove the directly heap using versions. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. The rballoc() calls are converted to mod_balloc(), except module pdata is allocated with mod_alloc() as its obviously not an audio buffer. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. However, the rtnr_stub's heap access, rtk_alloc() and rtk_free() still use heap directly like before. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. The IPC3 implementation of selector uses the component interface directly and can not use the new module API. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. The one rballoc() call is converted to mod_balloc(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. The two rballoc() calls are converted to mod_balloc(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends and remove all redundant rfree(), comp_data_blob_handler_free(), and fast_put() calls from module unload functions and init error branches. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Add mod_psy_free_mel_filterbank() for freeing the allocated memory. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix memory leaks from auditory cmocka test. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from fft test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from matrix test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Add mod_dct_free_16() to free memory allocated by mod_dct_initialize_16(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix memory leaks found by running the tests with Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix memory freeing error from module_adapter_test_free(). Use free_test_source() for sources, not free_test_sink(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from volume test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from mux_copy test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from demux_copy test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix all memory leaks found from all pipeline tests when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

…d_alloc()

The current rballoc_align() implementation has this line: assert(IS_ALIGNED(mem, align)); Which will cause division by zero due to IS_ALIGNED() Zephyr implementation: define IS_ALIGNED(ptr, align) (((uintptr_t)(ptr)) % (align) == 0) So better use sizeof(void *) as the default value. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

jsarha · 2025-11-12T14:37:42Z

All these commits, or their further developed versions have been merged.

jsarha force-pushed the module_api_rest_of_the_modules branch 3 times, most recently from 5a81bd2 to 69b18c4 Compare August 27, 2025 14:40

jsarha mentioned this pull request Aug 27, 2025

Module API additions and conversion of some modules to use them #10164

Merged

jsarha force-pushed the module_api_rest_of_the_modules branch 3 times, most recently from 6067aa8 to 32e83e3 Compare September 3, 2025 16:08

lgirdwood reviewed Sep 4, 2025

View reviewed changes

jsarha force-pushed the module_api_rest_of_the_modules branch 2 times, most recently from 6d16a80 to 8f5ea1c Compare September 4, 2025 18:33

jsarha marked this pull request as ready for review September 5, 2025 08:37

Copilot AI review requested due to automatic review settings September 5, 2025 08:37

jsarha requested review from a team, RanderWang, abonislawski, dabekjakub, dbaluta, fkwasowi, iuliana-prodan, kv2019i, lbetlej, lyakh, mmaka1, pblaszko, plbossart, singalsu and tlissows as code owners September 5, 2025 08:37

This comment was marked as outdated.

Sign in to view

jsarha force-pushed the module_api_rest_of_the_modules branch from 8f5ea1c to 2337ac2 Compare September 5, 2025 08:46

Jyri Sarha added 25 commits October 21, 2025 12:13

cmocka: math: Test using module memory API math function

2d06c9d

Convert auditory, dct, fft, and matrix math tests to use module heap API functions instead of the old version using rmalloc() and friends directly. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Math: Remove directly heap using math functions

573e07a

Both unit tests and modules should now use the module API heap allocation functions, so we can now remove the directly heap using versions. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Math: auditory: Add mod_psy_free_mel_filterbank()

47081fe

Add mod_psy_free_mel_filterbank() for freeing the allocated memory. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: math: auditiory: Fix memory leaks

8f30198

Fix memory leaks from auditory cmocka test. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: math: fft: Fix memory leaks

b334929

Fix all memory leaks found from fft test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: math: matrix: Fix memory leaks

bbb22ef

Fix all memory leaks found from matrix test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Math: DCT: Add mod_dct_free_16()

8d3cb4a

Add mod_dct_free_16() to free memory allocated by mod_dct_initialize_16(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: math: dct: Fix memory leaks

1f229a5

Fix memory leaks found by running the tests with Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: module_adapter_test: Fix memory freeing error

ee1a910

Fix memory freeing error from module_adapter_test_free(). Use free_test_source() for sources, not free_test_sink(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: volume: Fix memory leaks

7a331e6

Fix all memory leaks found from volume test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: mux_copy: Fix memory leaks

8b87136

Fix all memory leaks found from mux_copy test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: demux_copy: Fix memory leaks

01baab9

Fix all memory leaks found from demux_copy test when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

cmocka: pipeline: Fix memory leaks

f31234f

Fix all memory leaks found from all pipeline tests when tests were run under Valgrind. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

src/audio/module_adapter/module/generic.c: HACK: use rballoc() for mo…

fce2c50

…d_alloc()

jsarha force-pushed the module_api_rest_of_the_modules branch from c624018 to fce2c50 Compare October 21, 2025 09:13

jsarha force-pushed the module_api_rest_of_the_modules branch from f042224 to c449fe3 Compare October 24, 2025 12:17

jsarha closed this Nov 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Module api rest of the modules #10195

Module api rest of the modules #10195

Uh oh!

jsarha commented Aug 26, 2025 •

edited

Loading

Uh oh!

lgirdwood Sep 4, 2025

Uh oh!

jsarha Sep 4, 2025 •

edited

Loading

Uh oh!

jsarha Sep 4, 2025

Uh oh!

jsarha commented Sep 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

jsarha commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Module api rest of the modules #10195

Module api rest of the modules #10195

Uh oh!

Conversation

jsarha commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jsarha Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsarha Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

jsarha commented Sep 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

jsarha commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jsarha commented Aug 26, 2025 •

edited

Loading

jsarha Sep 4, 2025 •

edited

Loading