-
Notifications
You must be signed in to change notification settings - Fork 349
[SKIP SOFCI-TEST] ci: Remove XTOS-make-install job from daily-tests workflow #10145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The XTOS-make-install job is removed from the daily tests workflow since the workflow is no longer present in the sof repo. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
|
fixes daily job by removing the workflow no longer present after PR #9870 was merged removed the install workflow. This will unblock the daily workflow from executing. |
Adds a directive to disable the 'truthy' rule in yamllint for the close-stale workflow file. This matches all other workflows in the repo. No functional changes to the workflow logic. Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
|
also added another commit with the truthy line in the close-stale.yml workflow since it was missing and caused a CI failure in yamllint ... this can be in a separate PR if preferred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the XTOS-make-install job from the daily tests workflow because the referenced installer workflow is no longer present in the sof repository.
- Removes the XTOS-make-install job configuration from daily-tests.yml
- Adds a yamllint disable comment for truthy rule in close-stale.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/daily-tests.yml | Removes XTOS-make-install job that references non-existent installer.yml workflow |
| .github/workflows/close-stale.yml | Adds yamllint disable comment and blank line |
Comments suppressed due to low confidence (1)
| --- | ||
| name: "Close stale issues" | ||
|
|
||
| # yamllint disable-line rule:truthy |
Copilot
AI
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yamllint disable comment appears unrelated to the PR's stated purpose of removing the XTOS-make-install job. This change should either be explained in the PR description or removed.
| # yamllint disable-line rule:truthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be split out but just added as a separate commit
The XTOS-make-install job is removed from the daily tests
workflow since the workflow is no longer
present in the sof repo.
Signed-off-by: Christopher Turner christopher.g.turner@intel.com