Skip to content

Conversation

@cgturner1
Copy link
Contributor

The XTOS-make-install job is removed from the daily tests
workflow since the workflow is no longer
present in the sof repo.

Signed-off-by: Christopher Turner christopher.g.turner@intel.com

The XTOS-make-install job is removed from the daily tests
workflow since the workflow is no longer
present in the sof repo.

Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
@cgturner1
Copy link
Contributor Author

cgturner1 commented Jul 30, 2025

fixes daily job by removing the workflow no longer present after PR #9870 was merged removed the install workflow. This will unblock the daily workflow from executing.

@cgturner1 cgturner1 changed the title ci: Remove XTOS-make-install job from daily-tests workflow [SKIP SOFCI-TEST] ci: Remove XTOS-make-install job from daily-tests workflow Jul 30, 2025
Adds a directive to disable the 'truthy' rule in
yamllint for the close-stale workflow file.

This matches all other workflows in the repo.

No functional changes to the workflow logic.

Signed-off-by: Christopher Turner <christopher.g.turner@intel.com>
@cgturner1
Copy link
Contributor Author

cgturner1 commented Jul 30, 2025

also added another commit with the truthy line in the close-stale.yml workflow since it was missing and caused a CI failure in yamllint ... this can be in a separate PR if preferred

@cgturner1 cgturner1 requested a review from redzynix July 30, 2025 23:43
@cgturner1 cgturner1 marked this pull request as ready for review July 30, 2025 23:43
Copilot AI review requested due to automatic review settings July 30, 2025 23:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the XTOS-make-install job from the daily tests workflow because the referenced installer workflow is no longer present in the sof repository.

  • Removes the XTOS-make-install job configuration from daily-tests.yml
  • Adds a yamllint disable comment for truthy rule in close-stale.yml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/daily-tests.yml Removes XTOS-make-install job that references non-existent installer.yml workflow
.github/workflows/close-stale.yml Adds yamllint disable comment and blank line
Comments suppressed due to low confidence (1)

---
name: "Close stale issues"

# yamllint disable-line rule:truthy
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yamllint disable comment appears unrelated to the PR's stated purpose of removing the XTOS-make-install job. This change should either be explained in the PR description or removed.

Suggested change
# yamllint disable-line rule:truthy

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be split out but just added as a separate commit

@kv2019i kv2019i merged commit 117e460 into thesofproject:main Jul 31, 2025
37 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants