debug: debug_stream_slot: Fix a typo and remove unneeded newlines #10097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the log module registration and removes unnecessary newline characters from several log messages for consistency.
- Corrected the
debug_strem_slottypo inLOG_MODULE_REGISTER - Removed trailing
\nfromLOG_DBGandLOG_INFformat strings
Comments suppressed due to low confidence (1)
src/debug/debug_stream/debug_stream_slot.c:55
- Verify that the
LOG_DBGmacro automatically appends a newline; removing the explicit\nmay cause log entries to run together if the backend doesn't add line breaks.
LOG_DBG("Sending record %u id %u len %u", rec->seqno, rec->id, rec->size_words);
kv2019i
approved these changes
Jul 4, 2025
lyakh
approved these changes
Jul 7, 2025
lgirdwood
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.