-
Notifications
You must be signed in to change notification settings - Fork 349
[PTL] Topology2 - Add support to generate a topology for everest codec +HDMI-In capture #10048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CBala21
commented
Jun 9, 2025
- Added changes to create a topology binary with ace3 to support Everest codec on PTL platforms.
- Changes to create a topology binary with ace3 to support Everest codec+HDMI-in capture via I2S.
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bardliao pls take a look.
|
|
||
| # SSP codec topologies for PTL | ||
| # ES83x6 codec alone without HDMI-in capture | ||
| "cavs-es83x6\;sof-ptl-es83x6-ssp1\;PLATFORM=ptl,PREPROCESS_PLUGINS=nhlt,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a corresponding kernel change for the topology?
According to thesofproject/linux#5434, what we need is 'sof-ptl-es8336'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a corresponding kernel change for the topology? According to thesofproject/linux#5434, what we need is 'sof-ptl-es8336'
@bardliao : there is no specific changes for this topology file name. The idea is to keep the topology file name as generic and rename it to respective driver name later(es8326/8336). Please suggest, does it ok or need one to one mapping with driver name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have all required topology files upstream. So that users can use it when they get the topology form https://github.com/thesofproject/sof-bin without renaming. @lgirdwood @kv2019i What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bardliao : updated the patch as you suggested. please check. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, users should not have to rename files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBala21 .sof_tplg_filename = "sof-ptl-es8336", Will the -ssp1 suffix be added somewhere in the kernel? If not, I would suggest that we add a sof-ptl-es8336.tplg in the topology as the kernel may need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bardliao : Yes. The kernel will add the suffix SSP1 due to the quirk mask from kernel driver
.tplg_quirk_mask = SND_SOC_ACPI_TPLG_INTEL_SSP_NUMBER |
As of now, we are creating the tplg for SSP1. later if any product that requires for other SSP then should add the support in make file.
e65a329 to
181ffb1
Compare
Adding support to generate the topology binary with ace3 blob for the PTL products which contains everest SSP codec. Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
…apture Adding changes to create a topology binary with ace3 blob to support Es83x6 codec with HDMI-In capture via I2S. Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
181ffb1 to
1f6349b
Compare
|
@bardliao @CBala21 pls ping when thesofproject/linux#5434 is aligned/merged and then we can merge this. |
@lgirdwood : The kernel changes were got merged. Could you help to merge this topology changes. |