Skip to content

Conversation

@CBala21
Copy link
Contributor

@CBala21 CBala21 commented Jun 9, 2025

  1. Added changes to create a topology binary with ace3 to support Everest codec on PTL platforms.
  2. Changes to create a topology binary with ace3 to support Everest codec+HDMI-in capture via I2S.

@CBala21 CBala21 requested review from jsarha and ranj063 as code owners June 9, 2025 10:29
@CBala21 CBala21 requested review from bardliao, kv2019i and singalsu and removed request for jsarha and ranj063 June 9, 2025 10:29
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao pls take a look.


# SSP codec topologies for PTL
# ES83x6 codec alone without HDMI-in capture
"cavs-es83x6\;sof-ptl-es83x6-ssp1\;PLATFORM=ptl,PREPROCESS_PLUGINS=nhlt,\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a corresponding kernel change for the topology?
According to thesofproject/linux#5434, what we need is 'sof-ptl-es8336'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a corresponding kernel change for the topology? According to thesofproject/linux#5434, what we need is 'sof-ptl-es8336'

@bardliao : there is no specific changes for this topology file name. The idea is to keep the topology file name as generic and rename it to respective driver name later(es8326/8336). Please suggest, does it ok or need one to one mapping with driver name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have all required topology files upstream. So that users can use it when they get the topology form https://github.com/thesofproject/sof-bin without renaming. @lgirdwood @kv2019i What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao : updated the patch as you suggested. please check. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, users should not have to rename files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBala21 .sof_tplg_filename = "sof-ptl-es8336", Will the -ssp1 suffix be added somewhere in the kernel? If not, I would suggest that we add a sof-ptl-es8336.tplg in the topology as the kernel may need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao : Yes. The kernel will add the suffix SSP1 due to the quirk mask from kernel driver
.tplg_quirk_mask = SND_SOC_ACPI_TPLG_INTEL_SSP_NUMBER |
As of now, we are creating the tplg for SSP1. later if any product that requires for other SSP then should add the support in make file.

@CBala21 CBala21 force-pushed the ptl-Es8326+HDMI-In branch from e65a329 to 181ffb1 Compare June 10, 2025 10:02
CBala21 added 2 commits June 10, 2025 15:40
Adding support to generate the topology binary with ace3 blob for the PTL
products which contains everest SSP codec.

Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
…apture

Adding changes to create a topology binary with ace3 blob to support Es83x6
codec with HDMI-In capture via I2S.

Signed-off-by: Balamurugan C <balamurugan.c@intel.com>
@CBala21 CBala21 force-pushed the ptl-Es8326+HDMI-In branch from 181ffb1 to 1f6349b Compare June 10, 2025 10:11
@lgirdwood
Copy link
Member

@bardliao @CBala21 pls ping when thesofproject/linux#5434 is aligned/merged and then we can merge this.

@CBala21
Copy link
Contributor Author

CBala21 commented Jun 19, 2025

@bardliao @CBala21 pls ping when thesofproject/linux#5434 is aligned/merged and then we can merge this.

@lgirdwood : The kernel changes were got merged. Could you help to merge this topology changes.

@lgirdwood lgirdwood merged commit 92ae7d8 into thesofproject:main Jun 20, 2025
44 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants