rimage: Add support for resigning ace manifest #10032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ace 1.5 manifest to resign_image function. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Subtract the number of skipped bytes from the file size to avoid going beyond of memory buffer. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Copy data preceding the cse header to the output file. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
Copilot,
jxstelter,
lyakh,
marcinszkudlinski,
pjdobrowolski and
tmleman
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds support for the new ACE 1.5 manifest format in resign_image.
- Adjusts
image_endto subtract skipped bytes from total size - Extends manifest version checks and invokes
ri_manifest_sign_ace_v1_5 - Copies the extended manifest region before the CSE header into the output file
Comments suppressed due to low confidence (3)
tools/rimage/src/manifest.c:1733
- [nitpick] The variable 'i' is ambiguous; consider renaming it to something like 'header_offset' or 'skip_bytes' to clarify its purpose.
image->image_end = size - i;
tools/rimage/src/manifest.c:1783
- The return value of 'man_write_fw_mod' is ignored; capture and check its result so you can abort on write failures instead of proceeding silently.
man_write_fw_mod(image);
tools/rimage/src/manifest.c:1758
- You've added handling for ACE v1.5, but there aren’t any tests covering this new branch; please add unit tests for the ACE manifest path.
else if (image->adsp->man_ace_v1_5)
lgirdwood
approved these changes
May 26, 2025
tmleman
approved these changes
May 26, 2025
serhiy-katsyuba-intel
approved these changes
May 27, 2025
abonislawski
approved these changes
May 27, 2025
lyakh
approved these changes
May 27, 2025
softwarecki
changed the title
marcinszkudlinski
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ace 1.5 manifest to resign_image function. Subtract the number of skipped bytes from the file size to avoid going
beyond of memory buffer. Copy data preceding the cse header to the output file to preserve extended manifest.