Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented May 16, 2025

The 24.10 runner availability is not great and 24.10 is not strictly needed, so use 24.04LTS instead.

Copilot AI review requested due to automatic review settings May 16, 2025 14:02
@kv2019i kv2019i requested review from dbaluta and lgirdwood as code owners May 16, 2025 14:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow for the testbench build by switching the runner from Ubuntu 24.10 to Ubuntu 24.04LTS, aiming for better availability and stability.

  • Update the "runs-on" parameter in the testbench workflow.
  • Align the CI runner with a long-term support version for improved reliability.
Comments suppressed due to low confidence (1)

.github/workflows/testbench.yml:33

  • Consider verifying that all dependencies and tools used in the testbench are fully compatible with Ubuntu 24.04LTS to avoid unexpected issues.
runs-on: ubuntu-24.04

@kv2019i kv2019i changed the title github: workflow: use 24.04LTS for testbench build [SKIP SOFCI-TEST github: workflow: use 24.04LTS for testbench build May 16, 2025
@kv2019i kv2019i force-pushed the 202505-gh-testbench-runner branch from cbdcc44 to 201ac96 Compare May 16, 2025 14:06
@kv2019i kv2019i changed the title [SKIP SOFCI-TEST github: workflow: use 24.04LTS for testbench build [SKIP SOFCI-TEST] .github: workflow: use 24.04LTS for testbench build May 16, 2025
The 24.10 runner availability is not great and 24.10 is not
strictly needed, so use 24.04LTS instead.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202505-gh-testbench-runner branch from 201ac96 to 3f1b847 Compare May 16, 2025 14:15
@kv2019i
Copy link
Collaborator Author

kv2019i commented May 16, 2025

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTS runner good.

Comment on lines +41 to +42
# note: libasound-dev needed for testbench build which still
# requires system ALSA headers to be present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu @kv2019i testbench should use the same ALSA version as other tools to avoid any confusion.

@lgirdwood lgirdwood merged commit 050d5a4 into thesofproject:main Jun 30, 2025
42 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants