Skip to content

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented May 12, 2025

If logging is disabled, the sof_uuid variable in ipc4_get_drv() will be unused. Add an attribute to fix a compilation failure.

Failed build: https://github.com/thesofproject/sof/actions/runs/14970782671/job/42051045218?pr=10000

If logging is disabled, the sof_uuid variable in ipc4_get_drv() will
be unused. Add an attribute to fix a compilation failure.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Copilot AI review requested due to automatic review settings May 12, 2025 13:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation warning in ipc4_get_drv() where the sof_uuid variable is unused when logging is disabled. The key change is adding the __maybe_unused attribute to the sof_uuid pointer to suppress the compiler warning.

@lyakh lyakh mentioned this pull request May 12, 2025
comp_new and comp_idx in fuzz_isr() are only used with IPC3, move
their definitions under the #ifdef.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
Copy link
Collaborator Author

lyakh commented May 13, 2025

turns out #9998 already covers these and a couple more

@lyakh lyakh closed this May 13, 2025
@lyakh lyakh deleted the uuid branch July 16, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants