Fix upx-i11 reboot/shutdown/suspend takes too much time (~2 minutes) #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The P360 Tiny suffers from an irq storm issue like the T490s, so add an entry for it to tpm_tis_dmi_table, and force polling. There also previously was a report from the previous attempt to enable interrupts that involved a ThinkPad L490. So an entry is added for it as well. Cc: stable@vger.kernel.org Reported-by: Peter Zijlstra <peterz@infradead.org> # P360 Tiny Closes: https://lore.kernel.org/linux-integrity/20230505130731.GO83892@hirez.programming.kicks-ass.net/ Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> (cherry picked from commit e7d3e5c) Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Interrupts got recently enabled for tpm_tis. The interrupts initially works on the device but they will stop arriving after circa ~200 interrupts. On system reboot/shutdown this will cause a long wait (120000 jiffies). [jarkko@kernel.org: fix a merge conflict and adjust the commit message] Fixes: e644b2f ("tpm, tpm_tis: Enable interrupt test") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> (cherry picked from commit 95a9359)
The original patch which added the quirk would apply to all AAEON machines, which might or might not be valid. The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the i12 (Alder Lake) version is affected. UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing and confirmed by dmidecode). Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only. Fixes: 95a9359 ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11") Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
yaochunhung
as code owners
plbossart
approved these changes
May 25, 2023
ranj063
approved these changes
May 25, 2023
Collaborator
|
SOFCI TEST |
Collaborator
|
https://sof-ci.01.org/linuxpr/PR4377/build5112/devicetest/index.html and https://sof-ci.01.org/linuxpr/PR4377/build5113/devicetest/index.html were affected by |
Collaborator
|
Looks better now except https://sof-ci.01.org/linuxpr/PR4377/build5159/devicetest/index.html?model=GLK_BOB_DA7219&testcase=check-kmod-load-unload has a NULL dereference |
Member
Known issue @marc-hb, this is completely unrelated. It's been more than 2 years and we could never root-cause this one, see #2676 |
Collaborator
Author
|
picking up to remove the TPM from the possible sources of suspend/resume fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The reason for UPX-i11 failures in suspend/resume tests are caused by TPM interrupts being enabled now on the machines as it appears to work while they are not.
It is likely that the IRQ line is floating, but it is not known.
Anyways, disabling IRQ mode and using polling (as it has been the case) fixes the issues.
Picking a lenovo patch as well to avoid future merge issue when we get the patches back from mainline.