ASoC: SOF: bump ABI to 3.20 #3298
Conversation
kv2019i
requested review from
ajitkupandey,
bardliao,
lgirdwood,
marc-hb,
plbossart,
ranj063 and
ujfalusi
| /* SOF ABI version major, minor and patch numbers */ | ||
| #define SOF_ABI_MAJOR 3 | ||
| #define SOF_ABI_MINOR 18 | ||
| #define SOF_ABI_MINOR 20 |
There was a problem hiding this comment.
Note: The kernel does not implement ALL changes of 3.20, so we cannot claim kernel support the full ABI of 3.20. E.g. missing: thesofproject/sof#4808
And this is completely valid. We are not enforcing every firmware feature needs to be implemented by the kernel at the same time. But sometimes kernel features are done immediately (like the stop DMA).
So I think we should really drop this and go with #3296
Update SOF interface headers to match definitions of SOF2.0 release and ABI level 3.20.0. All SOF firmware interface changes are agreed and documented in https://github.com/orgs/thesofproject/projects/2 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
topic/abi-bump-to-3-20
branch
from
2fb44d8 to
e3c8851
Compare
|
@ujfalusi I took a look at splitting to separate ABI3.19 and ABI3.20 patches, but that ended up completely silly as there would be no changes (than s/19/20) in the patch for ABI3.20. I.e. this patch is gathering missed updates for ABI. Uh, this is not manageable approach. I'll close PR this for now. We need to come up with a maintainable way to update the kernel side headers. |
2 participants
I actually WOULD PREFER NOT TO MERGE THIS and go with #3296 instead, but uploading for reference and to facilitate discussion.As per discussion in #3296 , no change yet to version checks.
Here's a minimal patch to sync headers to definitions of SOF1.9 and SOF2.0 firmware releases and avoid the kernel warning about too old kernel when using these firmware releases (which will become very common soon).