add-run-command by sloev · Pull Request #50 · theskumar/python-dotenv

sloev · 2017-02-10T15:21:38Z

I think it would be neat if the dotenv cli tool had an option to run a given commandline WITH the environment vars sourced from specified file, like a RUNNER.

# using the env command to print out env
echo "foo=bar" > .env
$ dotenv -f .env env 
foo=bar

using mock for subprocess.call

…rs loaded from file

coveralls · 2017-02-10T15:25:09Z

Coverage increased (+0.4%) to 82.813% when pulling fcfbec5 on sloev:master into 9552db8 on theskumar:master.

coveralls · 2017-02-10T15:27:48Z

Coverage increased (+0.4%) to 82.813% when pulling 242dd97 on sloev:master into 9552db8 on theskumar:master.

coveralls · 2017-02-10T15:36:41Z

Coverage increased (+0.4%) to 82.813% when pulling ab08024 on sloev:master into 9552db8 on theskumar:master.

sloev · 2017-02-14T12:31:33Z

any news on merge ... ?

theskumar · 2017-02-16T13:23:40Z

Hi, sorry for keeping you guys waiting, this looks amazing!

I'll have sometime today to look into it and then merge release.

Thanks @sloev

theskumar

Hi @sloev, i tried the dotenv and it seems it removes the existing env variable and keeps what's in the .env file only. Ideally it should only update the non-existing variables, i.e. behavior of environ.set_dafault. https://github.com/theskumar/python-dotenv/blob/master/dotenv/main.py#L27

How to reproduce:

# .env file
FOO=BAR

Create a file called testrun.sh

!# /bin/bash
echo "From .env" $FOO
echo "From system env" $HOME

chmod a+x testrun.sh then use dotenv run testrun.sh

sloev · 2017-02-19T14:56:33Z

Thanks for the feedback.
I will look into conforming to expected behaviour tomorrow.
Yep, set_default is the way to go.

sloev · 2017-02-20T15:00:51Z

all fixed in 0d5e22c now using load_dotenv and os.environ instead.
This means that existing envs will be set_defaultedwith provided .env file.

…oxy)

coveralls · 2017-02-20T15:05:01Z

Coverage increased (+0.4%) to 82.813% when pulling 0d5e22c on sloev:master into 9552db8 on theskumar:master.

coveralls · 2017-02-20T15:05:01Z

Coverage increased (+0.4%) to 82.813% when pulling 0d5e22c on sloev:master into 9552db8 on theskumar:master.

coveralls · 2017-02-20T15:05:01Z

Coverage increased (+0.4%) to 82.813% when pulling 0d5e22c on sloev:master into 9552db8 on theskumar:master.

coveralls · 2017-02-20T15:05:02Z

Coverage increased (+0.4%) to 82.813% when pulling 0d5e22c on sloev:master into 9552db8 on theskumar:master.

theskumar · 2017-02-20T15:13:03Z

Given a test.sh file

~/work/theskumar/python-dotenv pr/50
(pytho…/venv)❯ cat test.sh
#!/bin/bash
echo "From .env" $hello
echo "From system" $HOME

Uninstalled and re-install the latest code from this PR.

~/work/theskumar/python-dotenv pr/50
(pytho…/venv)❯ pip uninstall python-dotenv
Uninstalling python-dotenv-0.6.3:
  /Users/theskumar/work/theskumar/python-dotenv/venv/bin/dotenv
  /Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/python-dotenv.egg-link
Proceed (y/n)? y
  Successfully uninstalled python-dotenv-0.6.3

~/work/theskumar/python-dotenv pr/50
(pytho…/venv)❯ pip install -e .
Obtaining file:///Users/theskumar/work/theskumar/python-dotenv
Requirement already satisfied (use --upgrade to upgrade): click>=5.0 in ./venv/lib/python2.7/site-packages (from python-dotenv==0.6.3)
Installing collected packages: python-dotenv
  Running setup.py develop for python-dotenv
Successfully installed python-dotenv

Now the run the dotenv run command:

~/work/theskumar/python-dotenv
(pytho…/venv)❯ dotenv run test.sh
Traceback (most recent call last):
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/bin/dotenv", line 9, in <module>
    load_entry_point('python-dotenv==0.6.3', 'console_scripts', 'dotenv')()
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/core.py", line 700, in __call__
    return self.main(*args, **kwargs)
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/core.py", line 680, in main
    rv = self.invoke(ctx)
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/core.py", line 1027, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/core.py", line 873, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/core.py", line 508, in invoke
    return callback(*args, **kwargs)
  File "/Users/theskumar/work/theskumar/python-dotenv/venv/lib/python2.7/site-packages/click/decorators.py", line 16, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/theskumar/work/theskumar/python-dotenv/dotenv/cli.py", line 45, in run
    call(args, env=os.environ)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Do you get the same error, or it's just me?

sloev · 2017-02-20T21:28:40Z

No i didnt get the same error. I will get back to you.

sloev · 2017-02-20T21:32:23Z

I think it is a non populated 'file' arg

uranusjr · 2017-09-19T07:57:29Z

I pulled out this idea and created https://github.com/uranusjr/python-dotenv-run. It uses os.execlp to run the command when possible, to avoid creating a subprocess, and the --override flag which I find useful.

theskumar · 2018-04-05T17:40:28Z

Done in #105

sloev added 4 commits February 10, 2017 16:10

add mock as dependency

c927f25

add test for new run command

56b5d4f

using mock for subprocess.call

add new run command that runs a given commandline with environment va…

df12631

…rs loaded from file

update readme to include new run command

8eaa50f

sloev mentioned this pull request Feb 10, 2017

missing cli option to run a given commandline #49

Closed

fix lint error

fcfbec5

sloev force-pushed the master branch from 242dd97 to 9082d32 Compare February 10, 2017 15:28

fix test with bad assertion on dict equal to OrderedDict

ab08024

sloev force-pushed the master branch from 9082d32 to ab08024 Compare February 10, 2017 15:34

theskumar requested changes Feb 16, 2017

View reviewed changes

sloev force-pushed the master branch from 6323499 to ac6f522 Compare February 20, 2017 14:55

refactor so it uses set_default on os.environ (with load_dotenv as pr…

0d5e22c

…oxy)

sloev force-pushed the master branch from ac6f522 to 0d5e22c Compare February 20, 2017 15:02

theskumar force-pushed the master branch from 7569670 to 41ec9ca Compare March 3, 2018 17:11

theskumar force-pushed the master branch from 8d7b38a to d541b6c Compare March 16, 2018 19:39

theskumar force-pushed the master branch from d541b6c to fe35be1 Compare March 16, 2018 19:55

theskumar closed this Apr 5, 2018

Conversation

sloev commented Feb 10, 2017

Uh oh!

coveralls commented Feb 10, 2017

Uh oh!

coveralls commented Feb 10, 2017

Uh oh!

coveralls commented Feb 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sloev commented Feb 14, 2017

Uh oh!

theskumar commented Feb 16, 2017

Uh oh!

theskumar left a comment

Choose a reason for hiding this comment

Uh oh!

sloev commented Feb 19, 2017

Uh oh!

sloev commented Feb 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Feb 20, 2017

Uh oh!

coveralls commented Feb 20, 2017

Uh oh!

coveralls commented Feb 20, 2017

Uh oh!

coveralls commented Feb 20, 2017

Uh oh!

theskumar commented Feb 20, 2017

Uh oh!

sloev commented Feb 20, 2017

Uh oh!

sloev commented Feb 20, 2017

Uh oh!

uranusjr commented Sep 19, 2017

Uh oh!

theskumar commented Apr 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Feb 10, 2017 •

edited

Loading

sloev commented Feb 20, 2017 •

edited

Loading