Add missing trailing newline before adding new entry with set_key#361
Merged
bbc2 merged 1 commit intotheskumar:masterfrom Nov 11, 2021
Merged
Add missing trailing newline before adding new entry with set_key#361bbc2 merged 1 commit intotheskumar:masterfrom
set_key#361bbc2 merged 1 commit intotheskumar:masterfrom
Conversation
Sometimes, the source file doesn't have a trailing newline. If we add a new binding in such a case, we need to add a newline before the new binding.
bbc2
force-pushed
the
add-missing-newline
branch
from
c0df525 to
2e0ac43
Compare
|
@theskumar, why has this not yet been merged? |
Collaborator
Author
|
I don't know the reason but I have to mention that we maintain this package in our spare time, so we're not always available to do code reviews. In my case, I like to leave my MRs open for a while so that other developers get a chance to comment on them. I think this one has waited long enough so I'm going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, the source file doesn't have a trailing newline. If we add a new binding in such a case, we need to add a newline before the new binding.
Closes #360.