Special __file__ handling for Python 2 (fixes #130)#152
Merged
bbc2 merged 1 commit intotheskumar:masterfrom Feb 16, 2019
Merged
Special __file__ handling for Python 2 (fixes #130)#152bbc2 merged 1 commit intotheskumar:masterfrom
bbc2 merged 1 commit intotheskumar:masterfrom
Conversation
theskumar
force-pushed
the
master
branch
2 times, most recently
from
f628767 to
f9863d3
Compare
Merged
Updated tests to show that this works.
Contributor
Author
|
I rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 2 the extension returned by
__file__can be either.pycor.pyoin addition to.py, which means #109 does not always work in Python 2.This fixes #130 and might be related to #124.
I added the
current_filevariable because modifying__file__didn't seem like a good idea (if it's even possible, I didn't try it).