Force environment variables to str with Python2 on Windows#101
Merged
theskumar merged 5 commits intotheskumar:masterfrom Oct 31, 2018
Merged
Force environment variables to str with Python2 on Windows#101theskumar merged 5 commits intotheskumar:masterfrom
theskumar merged 5 commits intotheskumar:masterfrom
Conversation
With Python2 on Windows, force environment variables to str to avoid "TypeError: environment can only contain strings " in Python's subprocess.py.
greyli
changed the title
theskumar
force-pushed
the
master
branch
2 times, most recently
from
d541b6c to
fe35be1
Compare
Contributor
Author
|
Any ideas? @theskumar |
Contributor
Author
uranusjr
added a commit
to pypa/pipenv
that referenced
this pull request
Jun 19, 2018
uranusjr
added a commit
to pypa/pipenv
that referenced
this pull request
Jun 19, 2018
techalchemy
pushed a commit
to pypa/pipenv
that referenced
this pull request
Jun 22, 2018
|
Why was this closed? AFAICS, the proposed fix was not applied and the latest release 0.9.1 still has this problem. This break Flask under Python 2.7 on Windows, beacause it uses python-dotenv automatically, if it is installed, when you use the |
Contributor
Author
|
@SpotlightKid I finally create a PR in Werkzeug to fix this issue on master(#1320), maybe we should fix it in python-dotenv too. Ok, I just reopen it, but the maintainer seems very busy... |
|
Yes, this should be definitely fixed in |
Owner
|
Thanks @greyli for taking this up! 👍 💟 |
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
…#101) * Force environment variables to str With Python2 on Windows, force environment variables to str to avoid "TypeError: environment can only contain strings " in Python's subprocess.py. * PEP8 fix * Add Python3 compatible * Fix flake8 fails with F821 * Fix flake8 fails with F821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Python2 on Windows, force environment variables to str to avoid "TypeError: environment can only contain strings" in Python's subprocess.py.
Fix #88