Fix RST errors in README.rst and test for errors#100
Merged
theskumar merged 1 commit intotheskumar:masterfrom Mar 7, 2018
Merged
Fix RST errors in README.rst and test for errors#100theskumar merged 1 commit intotheskumar:masterfrom
theskumar merged 1 commit intotheskumar:masterfrom
Conversation
The test is not run in Python 3.3 because of this bug: https://sourceforge.net/p/docutils/bugs/270/ Having valid RST is important so that Pypi's web interface interprets the RST correctly and display long_description in a pretty format.
1 similar comment
Owner
|
Looks great! Thanks @Flimm :) |
Owner
|
It doesn't fix the formatting on pypi though. :( |
theskumar
pushed a commit
that referenced
this pull request
Mar 7, 2018
This reverts commit 07fffa1.
Contributor
Author
|
That's so weird. That's the first time I've seen that |
Owner
|
Never mine. Converted the doc to markdown and now I'm converting to rst just before upload. Solves the issue and makes the little easier to maintain as well (atleast for me) |
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
The test is not run in Python 3.3 because of this bug: https://sourceforge.net/p/docutils/bugs/270/ Having valid RST is important so that Pypi's web interface interprets the RST correctly and display long_description in a pretty format.
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
…)" This reverts commit 07fffa1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having valid RST is important so that Pypi's web interface interprets the RST correctly and display
long_descriptionin a pretty format. Right now, the Pypi page looks pretty ugly:https://pypi.python.org/pypi/python-dotenv
This pull request fixes the errors, and also adds a simple test to avoid this problem in the future.