Skip to content
This repository was archived by the owner on Mar 15, 2019. It is now read-only.

Ability to define PHP application src dir / Bump Traefik to 1.4.3 for correct X-Forwarded* - #47

Merged
gulien merged 1 commit into
thecodingmachine:masterfrom
dkozickis:app-dir-traefik-bump
Nov 20, 2017
Merged

Ability to define PHP application src dir / Bump Traefik to 1.4.3 for correct X-Forwarded*#47
gulien merged 1 commit into
thecodingmachine:masterfrom
dkozickis:app-dir-traefik-bump

Conversation

@dkozickis

@dkozickis dkozickis commented Nov 15, 2017

Copy link
Copy Markdown
Contributor

Summary

This PR fixes/implements the following bugs/features

  • Add ability to define PHP application source directory
  • Bump Traefik to 1.4.3 to incorporate Enhance Trust Forwarded Headers traefik/traefik#2302 (enables proper X-Forwarded-Port for PHP frameworks depending on X-Forwarded* during URL generation e.g. Symfony with setTrustedProxies enabled)

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

* Bump Traefik to 1.4.3 to incorporate traefik/traefik#2302 (enables proper X-Forwarded-Port for PHP frameworks depending on X-Forwarded* during URL generation e.g. Symfony with setTrustedProxies enabled)
@gulien

gulien commented Nov 16, 2017

Copy link
Copy Markdown

Thank you for your PR!

I'll try to take a look at it asap 😄

@dkozickis

Copy link
Copy Markdown
Contributor Author

Thank you for this project!
Travis CI is passing -> https://travis-ci.org/dkozickis/kickoff-docker-php
Does not show up here for some reason.

@gulien
gulien merged commit 73adb92 into thecodingmachine:master Nov 20, 2017
@gulien

gulien commented Nov 20, 2017

Copy link
Copy Markdown

Merged! Thank you for your time @dkozickis 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants